iox-#1099 Separate test part from `ErrorHandler` and call `errorHandler()` in `iceoryx_hoofs` only once #1100

mossmaurice · 2022-02-12T22:27:47Z

Pre-Review Checklist for the PR Author

Notes for Reviewer

Separate test specific code from the ErrorHandler and templatize setTemporaryErrorHandler(..)
Call errorHandler(..) only once in iceoryx_hoofs in Expects / Ensures

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Code according to our coding style and naming conventions
Unit tests have been written for new behavior
- Each unit test case has a unique UUID
Public API changes are documented via doxygen
Copyright owner are updated in the changed files
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes Separate module specific errors from iceoryx_hoofs #1099 (partly)
Successor to iox-#590 Remove error handler calls from hoofs #1027

codecov · 2022-02-12T22:52:11Z

Codecov Report

Merging #1100 (28d6a5d) into master (418b483) will increase coverage by 0.01%.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
+ Coverage   78.93%   78.95%   +0.01%     
==========================================
  Files         370      371       +1     
  Lines       14705    14683      -22     
  Branches     2059     2051       -8     
==========================================
- Hits        11608    11593      -15     
+ Misses       2417     2415       -2     
+ Partials      680      675       -5

Flag	Coverage Δ
unittests	`78.17% <61.53%> (+<0.01%)`	⬆️
unittests_timing	`15.46% <15.38%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...clude/iceoryx_hoofs/internal/cxx/variant_queue.inl	`78.31% <ø> (ø)`
...iceoryx_hoofs/internal/file_reader/file_reader.hpp	`100.00% <ø> (ø)`
...eoryx_posh/internal/runtime/ipc_interface_base.hpp	`100.00% <ø> (ø)`
...oryx_posh/include/iceoryx_posh/roudi/roudi_app.hpp	`40.00% <ø> (ø)`
iceoryx_hoofs/source/file_reader/file_reader.cpp	`71.42% <50.00%> (-6.84%)`	⬇️
iceoryx_hoofs/source/posix_wrapper/timer.cpp	`65.53% <80.00%> (+2.46%)`	⬆️
...x_hoofs/internal/error_handling/error_handling.inl	`100.00% <100.00%> (ø)`
...ryx_hoofs/source/error_handling/error_handling.cpp	`60.00% <100.00%> (-7.57%)`	⬇️
iceoryx_hoofs/source/concurrent/loffli.cpp	`80.00% <0.00%> (-11.43%)`	⬇️
... and 1 more

elfenpiff

Please squash or reorder and squash some commits and revert some changes by dropping some commits like:

Update copyright header, this really clutters our git history.
The last two one liner commits.

Please create one commit here instead of 4 and add the copyright year findings to it.

I suggest to squash and drop the commits as a first step. After you done this we can go to the next review stage where you try to avoid rebasing/push force so that all the reviewers see only the changes. But lets start with a more or less clean git history and when it clutters up in the later review process then just let it clutter up.

elfenpiff · 2022-02-14T04:29:49Z

CONTRIBUTING.md

@@ -110,8 +110,8 @@ codebase follows these rules, things are work in progress.
    our code may contain additions which are not compatible with the STL (e.g. `iox::cxx::vector::emplace_back()`
    does return a bool)
 7) **Always use `iox::log::Logger`**, instead of `printf()`
-8) **Always use `iox::ErrorHandler()`**, when an error occurs that cannot or shall not be propagated via an
-    `iox::cxx::expected`, the `iox::ErrorHandler()` shall be used; exceptions are not allowed
+8) **Always use `iox::ErrorHandler()` or `cxx::Expects`/`cxx::Ensures`**, when an error occurs that cannot or shall not be propagated via an


In my opinion this will be very soon outdated when the low level error handler becomes also available for iceoryx hoofs. Then it would make sense to never use cxx::Expects / cxx::Ensures (even when they use the error handler behind the scenes).
I would state here right from the beginning: always use the iox::ErrorHandler since we can emit an error code here which can be important for later bug reports or debugging.

I do not think having indivual error codes in iceoryx hoofs (e.g. when a vector capacity is exceeded) is a good idea. In my opinion this does not belong into a generic library. We should use a generic hoofs error category (or categories, exception like).

Regardless, this is for another time and we should state how the handling is currently intended, even if it will change in the (near) future.

I don't think it makes sense to use errorHandler() in iceoryx_hoofs building blocks. IMHO it's more idiomatic and closer to a library philosophy to use Expects / Ensures and allow the users to call the errorHandler() inside Expects / Ensures (or throw or std::terminate).

However, we should not discuss this here, that's something for #1032

The goal for v2.0 is to decouple iceoryx_posh and iceoryx_binding_c from iceoryx_hoofs as an intermediate step. Hence, the description above is still valid.

cc @MatthiasKillat

elfenpiff · 2022-02-14T04:31:25Z

iceoryx_binding_c/test/test.hpp

@@ -17,6 +17,8 @@
 #ifndef IOX_DDS_GATEWAY_TEST_TEST_HPP
 #define IOX_DDS_GATEWAY_TEST_TEST_HPP

+#include "iceoryx_hoofs/testing/mocks/error_handler_mock.hpp"


Why do we actually require an error handler mock? We can always set a temporary error handler and check if it was called with the correct arguments?

Yes, I had the same observation in the previous PR. I do not think we require a mock or it is actually a mock, we just want to change to a different ErrorHandler for the tests (which is one reason to have a configurable ErrorHandler) . It somehow looks like a design flaw or I do not understand it correctly.

Should at least be considered in another refactoring pass.

The ErrorHandlerMock contains call code which is only needed in test code. Now, ErrorHandler on the other hand, contains the code needed during runtime of an iceoryx system and is not cluttered with test-only code anymore. The templatization of setTemporaryErrorHandler is necessary to provide a user friendly way to use a different error enums for each module (posh, C binding).

iceoryx_hoofs/include/iceoryx_hoofs/error_handling/error_handling.hpp

iceoryx_hoofs/source/error_handling/error_handling.cpp

elfenpiff · 2022-02-14T04:44:22Z

iceoryx_hoofs/source/file_reader/file_reader.cpp

+            std::cerr << "\033[5;31m"
+                      << "Could not open file '" << m_file << "'. Exiting!"
+                      << "\033[0m" << std::endl;
+            cxx::Ensures(false);


Since we will most likely use the error handler in the complete code base, why not use it here with a newly created enum to spare us some future work.

I would not do this in the scope of this PR since the concept is still not fully clear. Just cause no regression compared to previous code.

Reason: Global error handling cannot be applied if the user is supposed to somehow configure the error handling of FileReader individually (i.e. decoupled from the global error handling). And if it is just the terminate case Ensures is sufficient for now.

Sorry, I disagree with using the errorHandler() directly in iceoryx_hoofs. See this comment for the background. That's something to be discussed in #1032. For v2.0 I would like to implement our current error handling strategy as described in doc/design/error-handling.md to have a consistent code base.

elfenpiff · 2022-02-14T04:45:27Z

iceoryx_hoofs/source/posix_wrapper/timer.cpp

-                errorHandler(Error::kPOSIX_TIMER__INCONSISTENT_STATE);
-                return;
-            }
+            cxx::Expects((handle.m_timer != nullptr) && "Timer in inconsistent state");


Please use the error handler here and in all remaining files where you added an cxx::Expects / cxx::Ensures or where you removed the errorHandler.

Disagree. The entire point AFAIK is not to use the error handler in hoofs directly (and I agree with this). Expects may call or may not call it, this is implementation specific.

On another note Expects is just a runtime assert in its most basic form and I do not really see a reason to not name it Assert as we cannot use it as a true precondition check (enforced as a contract!) as the standard says https://doc.bccnsoft.com/docs/cppreference2018/en/cpp/language/attributes/contract.html (same with Ensures). To do so we need compiler support which we do not have (i.e. we cannot implement this in with C++17 alone).

Whenever something like this is checked in the function body it is an assert (as per the standard) and I would not deviate from this (as it has no point and just causes confusion).

Rejected, quote from doc/design/error-handling.md:

The error handler cannot be used in hoofs.

See this comment for the background an my opinion. For v2.0 I would like to implement our current error handling strategy.

I'm happy to discuss changes to the error handling strategy in #1032 for v3.0.

elfenpiff · 2022-02-14T04:49:21Z

iceoryx_hoofs/test/moduletests/test_posix_timer.cpp

    std::this_thread::sleep_for(std::chrono::milliseconds(TIMEOUT.toMilliseconds() * 10));
-    TIMING_TEST_EXPECT_FALSE(hasTerminated);
+    // EXPECT_NO_DEATH
+    EXPECT_TRUE(true);


Please revert the changes (in whole file). cxx::Expects / cxx::Ensures are calling the error handler and terminate the program. When this test fails the whole test is terminated and the user is wondering what happened.

If possible, a unit test should never die! We always want a list of all the failing unit tests with the condition/code line which failed - this test setup makes this impossible since we do not know if the test failed or some segfault occurred.

Please do this by dropping the commit otherwise we clutter or history with changes which actually never happened.

We should be able to exchange the error handling to some specific test handling where we do not terminate but indicate that an error occurred instead ... If this is not possible right now (why not?) it needs to be possible in the future at least (and a todo added).

Furthermore if the test success is determined at some point we should use SUCCEED().

But I thought we will get rid of the POSIX timer which would make all this a non-issue.

You're right, DEATH_TESTS should be avoided. However, this is an intermediate step as the posix::Timer and its tests will be removed before v2.0 e.g. by finishing off #754 or re-implementing it from scratch.

elfenpiff · 2022-02-14T04:51:33Z

iceoryx_hoofs/testing/include/iceoryx_hoofs/testing/mocks/error_handler_mock.hpp

@@ -0,0 +1,81 @@
+// Copyright (c) 2022 by Apex.AI Inc. All rights reserved.


Why do we need it and cannot use the setTemporaryErrorHandler?

Please drop this change from the history as well.

Now, the ErrorHandler is free from any test code, see more in my previous comment.

elBoberido · 2022-02-14T15:16:54Z

@mossmaurice can't promise to look at this anytime soon since I'm quite busy with the request-response feature

elBoberido

Looks good in general. I'm just not sure about the new death tests, since the make problems on macOS

elBoberido · 2022-02-26T22:52:12Z

iceoryx_hoofs/testing/include/iceoryx_hoofs/testing/mocks/error_handler_mock.hpp

+class ErrorHandlerMock : protected ErrorHandler
+{
+  public:
+    template <typename Error>
+    static cxx::GenericRAII setTemporaryErrorHandler(const TypedHandlerFunction<Error>& newHandler) noexcept;


Instead of having to call a function, why not make this the ctor?

That would be possible. However, using setTemporaryErrorHandler() in tests is more meaningful for me. I use a mock and call a method to set a certain behaviour.

For me it is the oposite. It's like with the std::lock. One creates the object and let it's dtor do everything.

iceoryx_hoofs/include/iceoryx_hoofs/error_handling/error_handling.hpp

iceoryx_posh/test/moduletests/test_popo_sample.cpp

mossmaurice · 2022-02-28T09:05:52Z

I'm just not sure about the new death tests, since the make problems on macOS

Let's delete the posix::Timer and its tests for good finally! This should be done right after v2.0

…ler() calls from hoofs Signed-off-by: Simon Hoinkis <[email protected]>

Signed-off-by: Simon Hoinkis <[email protected]>

…le 'handler' Signed-off-by: Simon Hoinkis <[email protected]>

…with errorHandler() Signed-off-by: Simon Hoinkis <[email protected]>

…void problems in tests Signed-off-by: Simon Hoinkis <[email protected]>

Signed-off-by: Simon Hoinkis <[email protected]>

…osh_testing Signed-off-by: Simon Hoinkis <[email protected]>

Signed-off-by: Simon Hoinkis <[email protected]>

… unexpected error enum type in error handler Signed-off-by: Simon Hoinkis <[email protected]>

… todo Signed-off-by: Simon Hoinkis <[email protected]>

Signed-off-by: Simon Hoinkis <[email protected]>

… in .inl Signed-off-by: Simon Hoinkis <[email protected]>

… includes Signed-off-by: Simon Hoinkis <[email protected]>

MatthiasKillat

Ok in general for the purpose of separating the error handling but we need to rethink some of the error handling in another issue. I also think ErrorHandlerMock is the wrong name, it is the TestErrorHandler or something like this.

What happened to typed_unique_id.hpp?

MatthiasKillat · 2022-02-14T14:08:03Z

CONTRIBUTING.md

@@ -110,8 +110,8 @@ codebase follows these rules, things are work in progress.
    our code may contain additions which are not compatible with the STL (e.g. `iox::cxx::vector::emplace_back()`
    does return a bool)
 7) **Always use `iox::log::Logger`**, instead of `printf()`
-8) **Always use `iox::ErrorHandler()`**, when an error occurs that cannot or shall not be propagated via an
-    `iox::cxx::expected`, the `iox::ErrorHandler()` shall be used; exceptions are not allowed
+8) **Always use `iox::ErrorHandler()` or `cxx::Expects`/`cxx::Ensures`**, when an error occurs that cannot or shall not be propagated via an


I do not think having indivual error codes in iceoryx hoofs (e.g. when a vector capacity is exceeded) is a good idea. In my opinion this does not belong into a generic library. We should use a generic hoofs error category (or categories, exception like).

Regardless, this is for another time and we should state how the handling is currently intended, even if it will change in the (near) future.

iceoryx_binding_c/test/moduletests/test_c2cpp_enum_translation.cpp

MatthiasKillat · 2022-02-14T14:13:44Z

iceoryx_binding_c/test/test.hpp

@@ -17,6 +17,8 @@
 #ifndef IOX_DDS_GATEWAY_TEST_TEST_HPP
 #define IOX_DDS_GATEWAY_TEST_TEST_HPP

+#include "iceoryx_hoofs/testing/mocks/error_handler_mock.hpp"


Yes, I had the same observation in the previous PR. I do not think we require a mock or it is actually a mock, we just want to change to a different ErrorHandler for the tests (which is one reason to have a configurable ErrorHandler) . It somehow looks like a design flaw or I do not understand it correctly.

Should at least be considered in another refactoring pass.

iceoryx_hoofs/include/iceoryx_hoofs/error_handling/error_handling.hpp

MatthiasKillat · 2022-03-15T09:40:28Z

iceoryx_hoofs/testing/include/iceoryx_hoofs/testing/mocks/error_handler_mock.hpp

+        // We undo the type erasure
+        auto typedError = static_cast<ErrorEnumType>(error);
+        typedHandler<iox::Error>.and_then(
+            [&](TypedHandlerFunction<Error> storedHandler) { storedHandler(typedError, level); });


Is it a storedHandler though? At this point it is merely a passed argument, nor will it be stored (so maybe only handler). Furthermore we pass by value here, is this a good idea/necessary since we call the function right away and are done. Could we encounter a dangling reference? If so, is it due to bad design or unavoidable or a misuse?

Yes, the handler is stored inside typedHandler. If the cxx::optional contains a value, this handler is invoked. It is not possible to encounter a dangling reference, as the resetting is done via a cxx::GenericRAII. Misuse is therefore very low. Semantically there is no change to before.

OK, but I mean in the context of the lambda it is meaningless whether it is/was stored or not so I would have dropped this from the name (it does not help clarity, it just adds confusion IMO).

But it is a small scope so I do not care too much.

iceoryx_hoofs/testing/include/iceoryx_hoofs/testing/mocks/error_handler_mock.hpp

MatthiasKillat · 2022-03-15T09:47:14Z

iceoryx_hoofs/testing/mocks/error_handler_mock.cpp

+
+namespace iox
+{
+std::mutex ErrorHandlerMock::handler_mutex;


Does this snake case break with our (local) conventions or is there more of a purpose?

I prefer snake case for certain library abstractions but not variables like this one, unless all variables in the module follow this convention.

But more importantly, it is a global variable in the iox namespace but is actually something specific to error handling. We should try to avoid polluting the iox namespace with this. If we cannot avoid the global mutex (can we confine it to some class as a static?) maybe it should live in something like iox::error_handling::detail.

The convention being that the any detail namespace is certainly not to be accessed by the user (even if it can be accessed to write a global variable like this one).

Fixed the snake case naming. We can think about wrapping parts of the error_handling in objects in an extra namespace. For me this not an important topic, as the class is already separate in a testing package. Hence, not a big deal for me.

iceoryx_posh/test/moduletests/test_popo_base_server.cpp

iceoryx_posh/test/moduletests/test_popo_sample.cpp

mossmaurice · 2022-03-15T11:33:47Z

Ok in general for the purpose of separating the error handling but we need to rethink some of the error handling in another issue. I also think ErrorHandlerMock is the wrong name, it is the TestErrorHandler or something like this.

Agree, that will happen as part of #1032.

What happened to typed_unique_id.hpp?

typed_unique_id.hpp was an empty left over file, which was forgotten in a previous PR.

Signed-off-by: Simon Hoinkis <[email protected]>

elBoberido

Can you please remove the empty typed_unique_id.hpp

iceoryx_hoofs/include/iceoryx_hoofs/error_handling/error_handling.hpp

iceoryx_hoofs/test/moduletests/test_posix_timer.cpp

elBoberido · 2022-03-15T13:15:36Z

iceoryx_hoofs/testing/include/iceoryx_hoofs/testing/mocks/error_handler_mock.hpp

+class ErrorHandlerMock : protected ErrorHandler
+{
+  public:
+    template <typename Error>
+    static cxx::GenericRAII setTemporaryErrorHandler(const TypedHandlerFunction<Error>& newHandler) noexcept;


For me it is the oposite. It's like with the std::lock. One creates the object and let it's dtor do everything.

elBoberido · 2022-03-15T13:18:10Z

iceoryx_hoofs/testing/include/iceoryx_hoofs/testing/mocks/error_handler_mock.hpp

+inline void errorHandlerForTest(const uint32_t error, const char* errorName, const ErrorLevel level) noexcept
+{
+    uint32_t errorEnumType = error >> 16;
+    uint32_t expectedErrorEnumType =


Shouldn't this just be 0 with a comment why it currently 0 and what will change?

iceoryx_hoofs/testing/include/iceoryx_hoofs/testing/mocks/error_handler_mock.hpp

mossmaurice · 2022-03-16T09:35:18Z

Can you please remove the empty typed_unique_id.hpp

@elBoberido It's already removed, maybe just harder to catch in GitHub web GUI due to being empty.

Findings addressed

mossmaurice added refactoring Refactor code without adding features technical debt unclean code and design flaws labels Feb 12, 2022

mossmaurice requested review from elBoberido and MatthiasKillat February 12, 2022 22:27

mossmaurice self-assigned this Feb 12, 2022

This was referenced Feb 12, 2022

iox-#590 Separate errors of posh and C binding #1028

Closed

iox-#590 Remove error handler calls from hoofs #1027

Closed

elfenpiff previously requested changes Feb 14, 2022

View reviewed changes

mossmaurice force-pushed the iox-#1099-separate-test-part-and-call-error-handler-in-hoofs-once branch from 068001c to 258bbcd Compare February 15, 2022 15:48

mossmaurice requested a review from elfenpiff February 15, 2022 17:52

mossmaurice force-pushed the iox-#1099-separate-test-part-and-call-error-handler-in-hoofs-once branch from 258bbcd to 907ad93 Compare February 15, 2022 17:53

mossmaurice force-pushed the iox-#1099-separate-test-part-and-call-error-handler-in-hoofs-once branch 2 times, most recently from bc69ced to 0f40aea Compare February 26, 2022 21:26

elBoberido reviewed Feb 26, 2022

View reviewed changes

mossmaurice force-pushed the iox-#1099-separate-test-part-and-call-error-handler-in-hoofs-once branch from 1ae5fd0 to 386f5c0 Compare February 28, 2022 08:07

mossmaurice requested a review from elBoberido February 28, 2022 08:14

mossmaurice mentioned this pull request Feb 28, 2022

iox-#1099 Separate error enums for each module #1170

Merged

21 tasks

mossmaurice force-pushed the iox-#1099-separate-test-part-and-call-error-handler-in-hoofs-once branch 2 times, most recently from d0d769e to c7a6cb4 Compare February 28, 2022 14:48

mossmaurice added 8 commits March 14, 2022 23:47

iox-eclipse-iceoryx#1099 Templatize ErrorHandler and remove errorHand…

a8867b7

…ler() calls from hoofs Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Update doxygen of error handler

622abc9

Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Remove double check in posix::Timer

a80aa05

Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Un-specialize the definiton of static variab…

1b3d3cd

…le 'handler' Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Fix posix::Timer unit test cases previously …

1d8b120

…with errorHandler() Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Use a typed and untyped HandlerFunction to a…

c603d76

…void problems in tests Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Use GTEST_FAIL instead of FAIL

4e35335

Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Link iceoryx_hoofs_testing against iceoryx_p…

f8cab6e

…osh_testing Signed-off-by: Simon Hoinkis <[email protected]>

mossmaurice added 10 commits March 14, 2022 23:47

iox-eclipse-iceoryx#1099 Carve out ErrorHandlerMock from ErrorHandler

ae00be5

Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Try to fix include error on CI

975d5be

Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Move ErrorHandlerMock to mock directory

8bd9079

Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Better output in case of failing test due to…

2bc2361

… unexpected error enum type in error handler Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Move mock to correct dir and remove obsolete…

174efa3

… todo Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Adapt new tests to ErrorHandler changes

92895ad

Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Move templated errorHandler() function to .inl

8ab73f1

Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Add changelog entry for ErrorHandler separation

463a133

Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Include VariantQueue and errorHandler header…

e7733cb

… in .inl Signed-off-by: Simon Hoinkis <[email protected]>

iox-eclipse-iceoryx#1099 Revert rebase errors and removed unnecessary…

6f8560e

… includes Signed-off-by: Simon Hoinkis <[email protected]>

mossmaurice force-pushed the iox-#1099-separate-test-part-and-call-error-handler-in-hoofs-once branch from c7a6cb4 to 6f8560e Compare March 14, 2022 22:55

MatthiasKillat reviewed Mar 15, 2022

View reviewed changes

iox-eclipse-iceoryx#1099 Rename snake case object in ErrorHandlerMock

e02d5c3

Signed-off-by: Simon Hoinkis <[email protected]>

mossmaurice requested a review from MatthiasKillat March 15, 2022 12:20

iox-eclipse-iceoryx#1099 Move changelog entry to unreleased

28d6a5d

Signed-off-by: Simon Hoinkis <[email protected]>

MatthiasKillat approved these changes Mar 15, 2022

View reviewed changes

elBoberido reviewed Mar 15, 2022

View reviewed changes

elBoberido approved these changes Mar 16, 2022

View reviewed changes

mossmaurice merged commit 86deed9 into eclipse-iceoryx:master Mar 16, 2022

mossmaurice deleted the iox-#1099-separate-test-part-and-call-error-handler-in-hoofs-once branch March 16, 2022 16:47

		@@ -0,0 +1,81 @@
		// Copyright (c) 2022 by Apex.AI Inc. All rights reserved.

iox-#1099 Separate test part from ErrorHandler and call errorHandler() in iceoryx_hoofs only once #1100

iox-#1099 Separate test part from ErrorHandler and call errorHandler() in iceoryx_hoofs only once #1100

Conversation

mossmaurice commented Feb 12, 2022 • edited Loading

Pre-Review Checklist for the PR Author

Notes for Reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

codecov bot commented Feb 12, 2022 • edited Loading

Codecov Report

elfenpiff left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mossmaurice Feb 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mossmaurice Feb 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elBoberido commented Feb 14, 2022

elBoberido left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mossmaurice Feb 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mossmaurice commented Feb 28, 2022 • edited Loading

MatthiasKillat left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mossmaurice Mar 15, 2022 • edited Loading

Choose a reason for hiding this comment

MatthiasKillat Mar 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mossmaurice commented Mar 15, 2022

elBoberido left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mossmaurice commented Mar 16, 2022 • edited Loading

iox-#1099 Separate test part from `ErrorHandler` and call `errorHandler()` in `iceoryx_hoofs` only once #1100

iox-#1099 Separate test part from `ErrorHandler` and call `errorHandler()` in `iceoryx_hoofs` only once #1100

mossmaurice commented Feb 12, 2022 •

edited

Loading

codecov bot commented Feb 12, 2022 •

edited

Loading

elfenpiff left a comment •

edited

Loading

mossmaurice Feb 15, 2022 •

edited

Loading

mossmaurice Feb 15, 2022 •

edited

Loading

mossmaurice Feb 28, 2022 •

edited

Loading

mossmaurice commented Feb 28, 2022 •

edited

Loading

MatthiasKillat left a comment •

edited

Loading

mossmaurice Mar 15, 2022 •

edited

Loading

MatthiasKillat Mar 15, 2022 •

edited

Loading

mossmaurice commented Mar 16, 2022 •

edited

Loading