Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup or Remove ObjectPool #66

Closed
elfenpiff opened this issue Mar 20, 2020 · 5 comments · Fixed by #2054
Closed

Cleanup or Remove ObjectPool #66

elfenpiff opened this issue Mar 20, 2020 · 5 comments · Fixed by #2054
Labels
globex good first issue Good for newcomers refactoring Refactor code without adding features
Milestone

Comments

@elfenpiff
Copy link
Contributor

Brief feature description

The object pool is in a very early stage and should be refactored/cleaned up or it should be removed. At the moment it is used nowhere.

Steps

  1. If ObjectPool is not needed - remove it. If needed, perform the rest of the steps
  2. follow up every todo and fix it.
  3. move implementation from header (hpp) into inline (inl) file
  4. cleanup unit tests (small unit tests with one or two EXPECT_*) with an behavior driven approach.
@elfenpiff elfenpiff added good first issue Good for newcomers refactoring Refactor code without adding features labels Mar 20, 2020
@mossmaurice mossmaurice added this to the v2.0 milestone Nov 4, 2020
@mossmaurice
Copy link
Contributor

mossmaurice commented Nov 4, 2020

@elfenpiff What is the current status? How much effort is this?

@ithier Why are you using this in the DDS gateway?

@dkroenke
Copy link
Member

This is linked to #488 where an uninitialized_array is used, please clarify first if the Objectpool is maybe obsolete.

@orecham
Copy link
Contributor

orecham commented Feb 2, 2021

I use this in the gateway implementation as a place for the gateway to create publishers/subscribers/data readers/data writers when doing dynamic discovery.
See here: https://github.com/eclipse-iceoryx/iceoryx/blob/master/iceoryx_posh/include/iceoryx_posh/gateway/channel.hpp#L82

We would either need another solution for this or to not support dynamic topic discovery if we wanted to remove the object pool.

@elBoberido
Copy link
Member

I think something like the ObjectPool is needed. Maybe with some refactoring and consolidation what we created after the ObjectPool.

@budrus
Copy link
Contributor

budrus commented Jan 7, 2022

@elfenpiff What do you think, how should we continue here?

@dkroenke dkroenke added the globex label Jun 8, 2022
elBoberido added a commit that referenced this issue Oct 22, 2023
elBoberido added a commit that referenced this issue Oct 24, 2023
elBoberido added a commit that referenced this issue Oct 24, 2023
elBoberido added a commit that referenced this issue Oct 25, 2023
elBoberido added a commit that referenced this issue Oct 25, 2023
elBoberido added a commit that referenced this issue Oct 27, 2023
@github-project-automation github-project-automation bot moved this to Done in v3.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
globex good first issue Good for newcomers refactoring Refactor code without adding features
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants