Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the signature of findService() to return InstanceContainer directly #387

Closed
nihalchari opened this issue Nov 23, 2020 · 1 comment

Comments

@nihalchari
Copy link

cxx::expected<InstanceContainer, Error> PoshRuntime::findService(const capro::ServiceDescription& serviceDescription) noexcept

This will overcome to deal with issues like:

  1. What to do if the provided InstanceContainer is full
  2. If we found a service should we look in the InstanceContainer if its already present.
  3. What is with entries which are out of date?

reference: #240

nihalchari pushed a commit to orecham/iceoryx that referenced this issue Nov 23, 2020
@nihalchari
Copy link
Author

fixed with #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant