Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow For memory chunks bigger than 4GB #2157

Closed
kozakusek opened this issue Jan 10, 2024 Discussed in #2149 · 2 comments · Fixed by #2158
Closed

Allow For memory chunks bigger than 4GB #2157

kozakusek opened this issue Jan 10, 2024 Discussed in #2149 · 2 comments · Fixed by #2158
Labels
enhancement New feature

Comments

@kozakusek
Copy link
Contributor

As discussed this seems to be a "technical unnecessary restriction."
From my experiments it seems possible to fix it by tweaking some of the types

Discussed in #2149

Originally posted by kozakusek January 3, 2024
When trying to start RouDi with a 4GB segment.mempool I encountered an unpleasant error:

 Condition: (t >= Minimum) && (t <= Maximum) in iox::range<T, Minimum, Maximum>::range(T) [with T = unsigned int; T Minimum = 1; T Maximum = 4294967255] is violated. (/workdir/iceoryx/iceoryx_hoofs/primitives/include/iox/algorithm.hpp:208)

Then after reading into the source code I noticed that in many cases (e.g. iox_pub_loan_chunk) the variable that refers to size is of type uint32_t.

Is there a reason for this limitation? Are you planning to add support for bigger memory chunks by adding option to hold size in 64bit integers?

Thanks

@elBoberido
Copy link
Member

@kozakusek looking forward to your PR :)

@elBoberido elBoberido added the enhancement New feature label Jan 10, 2024
@kozakusek
Copy link
Contributor Author

I've created a draft PR #2158.
I just need to delete the temporary modifications made in iceperf example and I think it will be ready for review.

In the meantime if you have a spare second I would apprieciate if you could check if I didn't messed up anything with the issue/commit/pr format 😃

kozakusek added a commit to kozakusek/iceoryx that referenced this issue Jan 30, 2024
kozakusek added a commit to kozakusek/iceoryx that referenced this issue Feb 1, 2024
kozakusek added a commit to kozakusek/iceoryx that referenced this issue Feb 1, 2024
elBoberido added a commit that referenced this issue Feb 2, 2024
iox-#2157 Replace uint32_t with uint64_t for payload size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants