Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test class for ctor and assignment operators to hoofs testing #2041

Closed
2 tasks done
elBoberido opened this issue Oct 15, 2023 · 1 comment · Fixed by #2042 or #2058
Closed
2 tasks done

Move test class for ctor and assignment operators to hoofs testing #2041

elBoberido opened this issue Oct 15, 2023 · 1 comment · Fixed by #2042 or #2058
Assignees
@elBoberido
Labels
technical debt unclean code and design flaws test A module/integration/stress/etc test for a component

Comments

@elBoberido
Copy link
Member

elBoberido commented Oct 15, 2023 •
edited
Loading

Brief feature description

The test class from the iox::vector was duplicated for the iox::list and iox::forward_list. In order to remove the code duplication and make it available for other tests the class should be refactored out into a separate file in hoofs testing.

Tasks

  • Make test class to separate file
  • Find a better name
@elBoberido elBoberido added test A module/integration/stress/etc test for a component technical debt unclean code and design flaws labels Oct 15, 2023
@elBoberido elBoberido self-assigned this Oct 15, 2023
elBoberido added a commit that referenced this issue Oct 15, 2023
@elBoberido
iox-#2041 Move 'CTorTest' to 'iox::testing::CTorAndAssignmentOperator…
61c5fb0 
…TestClass'
elBoberido added a commit that referenced this issue Oct 15, 2023
@elBoberido
iox-#2041 Port 'forward_list' tests to 'iox::testing::CTorAndAssignme…
1dc8b01 
…ntOperatorTestClass'
elBoberido added a commit that referenced this issue Oct 15, 2023
@elBoberido
iox-#2041 Port 'list' tests to 'iox::testing::CTorAndAssignmentOperat…
d431dd3 
…orTestClass'
elBoberido added a commit that referenced this issue Oct 15, 2023
@elBoberido
iox-#2041 Move 'CTorTest' to 'iox::testing::CTorAndAssignmentOperator…
2c84e72 
…TestClass'
elBoberido added a commit that referenced this issue Oct 15, 2023
@elBoberido
iox-#2041 Port 'forward_list' tests to 'iox::testing::CTorAndAssignme…
e46f2c7 
…ntOperatorTestClass'
elBoberido added a commit that referenced this issue Oct 15, 2023
@elBoberido
iox-#2041 Port 'list' tests to 'iox::testing::CTorAndAssignmentOperat…
bb3f029 
…orTestClass'
elBoberido added a commit that referenced this issue Oct 15, 2023
@elBoberido
iox-#2041 Update release notes
0388415
@elBoberido elBoberido mentioned this issue Oct 15, 2023
Merged
21 tasks
elBoberido added a commit that referenced this issue Oct 15, 2023
@elBoberido
iox-#2041 Update link to hyrumslaw
3b56e28
elBoberido added a commit that referenced this issue Oct 24, 2023
@elBoberido
iox-#2041 Move 'CTorTest' to 'iox::testing::CTorAndAssignmentOperator…
ff5a619 
…TestClass'
elBoberido added a commit that referenced this issue Oct 24, 2023
@elBoberido
iox-#2041 Port 'forward_list' tests to 'iox::testing::CTorAndAssignme…
9f02c90 
…ntOperatorTestClass'
elBoberido added a commit that referenced this issue Oct 24, 2023
@elBoberido
iox-#2041 Port 'list' tests to 'iox::testing::CTorAndAssignmentOperat…
f45b9ad 
…orTestClass'
elBoberido added a commit that referenced this issue Oct 24, 2023
@elBoberido
iox-#2041 Update release notes
91ec2be
@elBoberido
Copy link
Member Author

@mossmaurice let's continue #2042 (comment) here

Your suggestions for a name are

  • LifetimeVerificator
  • LifetimeTracker
  • CTorAndAssignmentCounterClass
  • StatisticalObjectMonitor
  • ObjectLifetimeInspector
  • LifetimeRecorder

My counter proposal is

  • LifetimeAndAssignmentTracker

elBoberido added a commit that referenced this issue Oct 24, 2023
@elBoberido
Merge pull request #2042 from eclipse-iceoryx/iox-2041-move-test-clas…
c5f549f 
…s-for-ctor-and-assignment-operator-to-hoofs-testing

iox-#2041 Move test class for ctor and assignment operator to hoofs testing
@elBoberido elBoberido linked a pull request Oct 24, 2023 that will close this issue
iox-#2041 Move test class for ctor and assignment operator to hoofs testing #2042
Merged
21 tasks
elBoberido added a commit that referenced this issue Oct 24, 2023
@elBoberido
iox-#2041 Rename 'CTorAndAssignmentOperatorTestClass' to 'LifetimeAnd…
c0fb9d4 
…AssignmentTracker'
@elBoberido elBoberido mentioned this issue Oct 24, 2023
Merged
21 tasks
@elBoberido elBoberido linked a pull request Oct 24, 2023 that will close this issue
iox-#2041 Rename 'CTorAndAssignmentOperatorTestClass' to 'LifetimeAndAssignmentTracker' #2058
Merged
21 tasks
elBoberido added a commit that referenced this issue Oct 25, 2023
@elBoberido
iox-#2041 Rename 'CTorAndAssignmentOperatorTestClass' to 'LifetimeAnd…
a9a4a22 
…AssignmentTracker'
elBoberido added a commit that referenced this issue Oct 25, 2023
@elBoberido
iox-#2041 Rename 'CTorAndAssignmentOperatorTestClass' to 'LifetimeAnd…
50ced06 
…AssignmentTracker'
elBoberido added a commit that referenced this issue Oct 30, 2023
@elBoberido
Merge pull request #2058 from eclipse-iceoryx/iox-2041-rename-test-class
b1c74a1 
iox-#2041 Rename 'CTorAndAssignmentOperatorTestClass' to 'LifetimeAndAssignmentTracker'
elBoberido added a commit that referenced this issue Oct 30, 2023
@elBoberido
iox-#2041 Rename 'CTorAndAssignmentOperatorTestClass' to 'LifetimeAnd…
0ffeb62 
…AssignmentTracker'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elBoberido elBoberido

Labels
technical debt unclean code and design flaws test A module/integration/stress/etc test for a component
Projects
None yet
Milestone
No milestone
1 participant
@elBoberido