Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add equality operators to cxx::variant and cxx::expected #1751

Closed
mossmaurice opened this issue Oct 19, 2022 · 1 comment · Fixed by #1757
Closed

Add equality operators to cxx::variant and cxx::expected #1751

mossmaurice opened this issue Oct 19, 2022 · 1 comment · Fixed by #1757
Assignees
@mossmaurice
Labels
enhancement New feature

Comments

@mossmaurice
Copy link
Contributor

mossmaurice commented Oct 19, 2022 •
edited
Loading

Brief feature description

Add the equality operators operator==() and operator!=() to cxx::variant and cxx::expected outside of the class to follow AUTOSAR rule A13-5-5.
@mossmaurice mossmaurice added the enhancement New feature label Oct 19, 2022
@mossmaurice mossmaurice self-assigned this Oct 19, 2022
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 20, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::expected'
429348a 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 20, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::variant'
aa337f0 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 20, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add release note entry for equality operators
ee3940c 
Signed-off-by: Simon Hoinkis <[email protected]>
@mossmaurice mossmaurice mentioned this issue Oct 20, 2022
Merged
21 tasks
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 20, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::variant'
5d488b3 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 20, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add release note entry for equality operators
b63a604 
Signed-off-by: Simon Hoinkis <[email protected]>
@elfenpiff
Copy link
Contributor

Neither expected nor variant have implemented a comparison operator so why add them now? What kind of purpose/feature would we cover with it?

mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Replace 'assert's with 'Expects'
625426e
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::expected'
a843c87 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::variant'
d15c774 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add release note entry for equality operators
e57955c 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Replace 'assert's with 'Expects'
089b7ec
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::expected'
f27c67c 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::variant'
28ffd93 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add release note entry for equality operators
d512da1 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Replace 'assert's with 'Expects'
4ca226d
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::expected'
bf084f0 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::variant'
c43a016 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add release note entry for equality operators
c8f2e6b 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Replace 'assert's with 'Expects'
e8a62bb
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Fix typo in docs
eb19aa0 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::expected'
fd62fca 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::variant'
e4efc38 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add release note entry for equality operators
58952ae 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Replace 'assert's with 'Expects'
099f193
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Fix typo in docs
06a7352 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::expected'
aaf8074 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::variant'
d51e3ad 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add release note entry for equality operators
6ec853c 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Replace 'assert's with 'Expects'
eb68c54
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Fix typo in docs
c861bb9 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::expected'
e3fb150 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add equality operators for 'cxx::variant'
f3a5c80 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Add release note entry for equality operators
69009d0 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Replace 'assert's with 'Expects'
a1cc928
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Oct 26, 2022
@mossmaurice
iox-eclipse-iceoryx#1751 Fix typo in docs
0956f1c 
Signed-off-by: Simon Hoinkis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossmaurice mossmaurice

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iox-1751 Add equality operators for expected and variant ApexAI/iceoryx
2 participants
@mossmaurice @elfenpiff