Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BumpAllocator #1732

Closed
FerdinandSpitzschnueffler opened this issue Oct 12, 2022 · 0 comments · Fixed by #1820
Closed

Implement BumpAllocator #1732

FerdinandSpitzschnueffler opened this issue Oct 12, 2022 · 0 comments · Fixed by #1820
Assignees
@FerdinandSpitzschnueffler
Labels
enhancement New feature globex refactoring Refactor code without adding features
Milestone
High prio

Comments

@FerdinandSpitzschnueffler
Copy link
Contributor

Brief feature description

Currently we have (at least) two classes to allocate memory: posix::Allocator and cxx::static_storage, where cxx::static_storage is basically posix::Allocator but with internal storage. To have a more generic and reusable allocator, we can remove the internal storage from cxx::static_storage, merge it with posix::Allocator and rename it to BumpAllocator (as known in literature). This allocator class can use the unintialized_array (#1614) underneath.

For the storable_function, this means that the storage needs then to be moved to the storable_function and the BumpAllocator needs to be initialized with a pointer to this storage.
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler added enhancement New feature refactoring Refactor code without adding features globex labels Oct 12, 2022
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler added this to the High prio milestone Oct 12, 2022
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 17, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove static_storage from storable_function
24bdec8 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 21, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Squash me!
3eda51e 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 22, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Squash me!
5e3ff7a 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 29, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move and rename shared memory object allocator
3b85941 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 30, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move and rename shared memory object allocator
fa5e291 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 30, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove alignment constant, fix allocate func…
6786ba4 
…tion

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Implement deallocate method
2bca7d5 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 5, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Implement deallocate method
0dbb60f 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 6, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Change allocate return type to expected
1c5ab8c 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 6, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Adapt allocate method
12f38bc 
Change return type to expected, remove option to finalize allocation

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 6, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move static_storage to iceoryx_dust
c9bbc74 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 6, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move static_storage to iceoryx_dust
476970b 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move static_storage to iceoryx_dust
e77a84e 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove static_storage from storable_function
b8eadbd 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move and rename shared memory object allocator
4dd291f 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove alignment constant, fix allocate func…
7096ffb 
…tion

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Implement deallocate method
54bd29c 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Adapt allocate method
4be18a7 
Change return type to expected, remove option to finalize allocation

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move static_storage to iceoryx_dust
0c54a79 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove static_storage from storable_function
053eb51 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move and rename shared memory object allocator
6fedeab 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove alignment constant, fix allocate func…
4c7163b 
…tion

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Dec 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Implement deallocate method
648e6d6 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Rework bump allocator tests
6e00feb 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Rename allocate and make function static con…
57d896f 
…stexpr

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove static_storage from storable_function
8ab5792 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move and rename shared memory object allocator
e50d063 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove alignment constant, fix allocate func…
cd97eb4 
…tion

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Implement deallocate method
5ed71ff 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Adapt allocate method
d30da5e 
Change return type to expected, remove option to finalize allocation

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move static_storage to iceoryx_dust
c105b3b 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Fix Bazel build
5f29621 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Refactor allocate methods
bb22222 
Change return type of SharedMemoryObject::allocate to expected,
introduce error enums

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Make Capacity second template parameter of a…
f00972a 
…llocate

Correct required storage size, rename some variables

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Rework bump allocator tests
8264fb1 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Rename allocate and make function static con…
742504c 
…stexpr

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Rename allocate and make function static con…
2f10b5d 
…stexpr

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Rename allocate and make function static con…
af4c307 
…stexpr

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Fix BumpAllocator tests
b15e2ef 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove static_storage from storable_function
7fd4e06 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move and rename shared memory object allocator
8937e66 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Remove alignment constant, fix allocate func…
69346de 
…tion

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Implement deallocate method
7ca205f 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Adapt allocate method
efe93d4 
Change return type to expected, remove option to finalize allocation

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Move static_storage to iceoryx_dust
ae2f65f 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Fix Bazel build
8245abb 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Refactor allocate methods
2fc7713 
Change return type of SharedMemoryObject::allocate to expected,
introduce error enums

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Make Capacity second template parameter of a…
45eb158 
…llocate

Correct required storage size, rename some variables

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Rework bump allocator tests
67fe3c1 
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Rename allocate and make function static con…
aa1bb90 
…stexpr

Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Jan 18, 2023
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1732 Fix BumpAllocator tests, AUTOSAR violations …
c00a5cf 
…in static_storage

Signed-off-by: Marika Lehmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler

Labels
enhancement New feature globex refactoring Refactor code without adding features
Projects
None yet
Milestone
High prio
Development

Successfully merging a pull request may close this issue.

iox-1732 implement bump allocator ApexAI/iceoryx
1 participant
@FerdinandSpitzschnueffler