Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move macro code from cxx/attributes.hpp into iceoryx_platform #1726

Closed
elfenpiff opened this issue Oct 10, 2022 · 2 comments · Fixed by #1789
Closed

Move macro code from cxx/attributes.hpp into iceoryx_platform #1726

elfenpiff opened this issue Oct 10, 2022 · 2 comments · Fixed by #1789
Assignees
@mossmaurice
Labels
globex refactoring Refactor code without adding features
Milestone
High prio

Comments

@elfenpiff
Copy link
Contributor

Brief feature description

Attributes like IOX_NO_DISCARD provide the same functionality even on platforms which do not support them natively or at least let the code compile without warning.
This functionality requires platform/compiler dependent macros and should be moved to iceoryx_platform to remove those macros.
@elfenpiff elfenpiff added this to the High prio milestone Oct 10, 2022
@elfenpiff elfenpiff self-assigned this Oct 10, 2022
@elBoberido
Copy link
Member

We have to be careful with this. Ideally the platform could depend on the primitives module but then the platform must be in hoofs. Maybe we can have a common folder in platform and add an include trampoline for attributes.hpp in hoofs.

@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Nov 14, 2022
@mossmaurice mossmaurice assigned mossmaurice and unassigned elfenpiff Nov 15, 2022
@mossmaurice
Copy link
Contributor

Picking up this issue and start working on it.

mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Nov 15, 2022
@mossmaurice
iox-eclipse-iceoryx#1726 Move IOX_NO_DISCARD, IOX_FALLTHROUGH and IOX…
2b8442f 
…_MAYBE_UNUSED to iceoryx_platform

Signed-off-by: Simon Hoinkis <[email protected]>
@mossmaurice mossmaurice mentioned this issue Nov 15, 2022
Merged
21 tasks
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Nov 15, 2022
@mossmaurice
iox-eclipse-iceoryx#1726 Move IOX_NO_DISCARD, IOX_FALLTHROUGH and IOX…
8b61eed 
…_MAYBE_UNUSED to iceoryx_platform

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 20, 2022
@mossmaurice
iox-eclipse-iceoryx#1726 Add release note entry for moving the custom…
49e1d7d 
… attributes

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 20, 2022
@mossmaurice
iox-eclipse-iceoryx#1726 Move IOX_NO_DISCARD, IOX_FALLTHROUGH and IOX…
909978f 
…_MAYBE_UNUSED to iceoryx_platform

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Dec 20, 2022
@mossmaurice
iox-eclipse-iceoryx#1726 Add release note entry for moving the custom…
84a1d88 
… attributes

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 2, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 Move IOX_NO_DISCARD, IOX_FALLTHROUGH and IOX…
1f43c45 
…_MAYBE_UNUSED to iceoryx_platform

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 2, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 Add release note entry for moving the custom…
86e5520 
… attributes

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 10, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 Address review findings by simplifying ifdef…
e2bc578 
… thicket

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 10, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 Address review findings by simplifying ifdef…
3d0bb55 
… thicket

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 11, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 UNIX build uses C++17 and can use plain [[ma…
f89ede6 
…ybe_unused]]

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 Remove 'gnu::warn_unused' which doesn't do t…
3b88b3c 
…he expected

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 Move IOX_NO_DISCARD, IOX_FALLTHROUGH and IOX…
7eb801c 
…_MAYBE_UNUSED to iceoryx_platform

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 Add release note entry for moving the custom…
62b0480 
… attributes

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 Address review findings by simplifying ifdef…
d103114 
… thicket

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 UNIX build uses C++17 and can use plain [[ma…
187bc98 
…ybe_unused]]

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 16, 2023
@mossmaurice
iox-eclipse-iceoryx#1726 Remove 'gnu::warn_unused' which doesn't do t…
b94a60d 
…he expected

Signed-off-by: Simon Hoinkis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossmaurice mossmaurice

Labels
globex refactoring Refactor code without adding features
Projects
None yet
Milestone
High prio
Development

Successfully merging a pull request may close this issue.

iox-1726 Move some attributes to iceoryx_platform ApexAI/iceoryx
3 participants
@mossmaurice @elfenpiff @elBoberido