Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup helplets #1560

Closed
1 of 2 tasks
elBoberido opened this issue Aug 3, 2022 · 0 comments · Fixed by #1561 or #1858
Closed
1 of 2 tasks

Cleanup helplets #1560

elBoberido opened this issue Aug 3, 2022 · 0 comments · Fixed by #1561 or #1858
Assignees
@mossmaurice
Labels
globex refactoring Refactor code without adding features technical debt unclean code and design flaws
Milestone
High prio

Comments

@elBoberido
Copy link
Member

elBoberido commented Aug 3, 2022 •
edited
Loading

Brief feature description

The cxx/helplets.hpp contains many unrelated or even unused code.

Detailed information

The unused code should be removed and at least functions which can be grouped together could be moved to a separate file

Tasks

  • remove functions which are unused or only used in one location
  • move function groups to a separate file when it makes sense
@elBoberido elBoberido added refactoring Refactor code without adding features technical debt unclean code and design flaws globex labels Aug 3, 2022
@elBoberido elBoberido added this to the High prio milestone Aug 3, 2022
@elBoberido elBoberido self-assigned this Aug 3, 2022
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove forEach from helplets
5f2845c
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Rename strlen2 to arrayCapacity
25ac120
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove enumTypeAsUnderlyingType
fcc00ad
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove convertEnumToString
514744e
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Update release notes
1cd601d
@elBoberido elBoberido mentioned this issue Aug 3, 2022
Merged
22 tasks
@elBoberido elBoberido linked a pull request Aug 3, 2022 that will close this issue
iox-#1560 remove rarely used functions from helplets and refactor strlen2 #1561
Merged
22 tasks
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Rename strlen2 to arrayCapacity
0726333
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove enumTypeAsUnderlyingType
8a388b9
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove convertEnumToString
855e32a
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Update release notes
aec719e
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Rename strlen2 to arrayCapacity
b745d78
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove enumTypeAsUnderlyingType
18acf58
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove convertEnumToString
7bc3872
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Update release notes
6eea9d8
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Make test names UpperCamelCase
7892a27
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Update release notes
e495d7a
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Make test names UpperCamelCase
279b15e
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 8, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove forEach from helplets
6902ddc
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 8, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Rename strlen2 to arrayCapacity
7bd2dc2
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 8, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove enumTypeAsUnderlyingType
59fc5cb
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 8, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Remove convertEnumToString
5a905ef
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 8, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Update release notes
a81ba26
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 8, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Make test names UpperCamelCase
29ed733
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Aug 8, 2022
@elBoberido
iox-eclipse-iceoryx#1560 Fix doxygen documentation
d75fd7e
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Fix Bazel build and includes
28ebf62 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Add release note entry for 'helplets.hpp' split
c921216 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Add release note entry for 'helplets.hpp' split
97b8a03 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Remove obsolete includes of 'helplets.hpp'
06e6f05 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 27, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Remove obsolete includes of 'helplets.hpp'
3b918c5 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 28, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Remove obsolete includes of 'helplets.hpp'
6698bcc 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 30, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Add release note entry for 'helplets.hpp' split
22e2f2f 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 30, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Remove obsolete includes of 'helplets.hpp'
604472e 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 30, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move isCompiledOn32BitSystem to 'system_conf…
c9ee555 
…iguration.hpp' and remove GCC diagnostic suppressions

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 30, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move left-overs in 'helplets.hpp' to separat…
2fe0515 
…e files

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 30, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move left-overs in 'helplets.hpp' to separat…
efaabe7 
…e files

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 30, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move left-overs in 'helplets.hpp' to separat…
5864618 
…e files

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Jan 30, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move left-overs in 'helplets.hpp' to separat…
d642104 
…e files

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Cleanup helplets
de8f8ff 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move 'BestFittingType' to the algorithm header
c55c23f 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move few classes from helplets to algorithm …
03bac2a 
…header

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move isPowerOfTwo to the algorithm header
7f487ed 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Renam 'algorithm' namespace and move memory-…
42d8cb3 
…related functions to 'memory.hpp'

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move 'convert.hpp' and 'serialization.hpp' t…
0d8663a 
…o 'iceoryx_dust'

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move 'into' into separate file
542a268 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move filesystem-related methods from 'helple…
aa292b2 
…ts.hpp' to 'filesystem.hpp'

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Remove unnecessary includes and use stringst…
db36e1a 
…ream for 'float' and 'double' in 'LogStream' tests

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Update Readme's and used headers
e3bc947 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Fix Bazel build and includes
d09136e 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Add release note entry for 'helplets.hpp' split
b3d0922 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Remove obsolete includes of 'helplets.hpp'
682187b 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move isCompiledOn32BitSystem to 'system_conf…
2f7383d 
…iguration.hpp' and remove GCC diagnostic suppressions

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Feb 1, 2023
@mossmaurice
iox-eclipse-iceoryx#1560 Move left-overs in 'helplets.hpp' to separat…
c22d147 
…e files

Signed-off-by: Simon Hoinkis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossmaurice mossmaurice

Labels
globex refactoring Refactor code without adding features technical debt unclean code and design flaws
Projects
None yet
Milestone
High prio
2 participants
@mossmaurice @elBoberido