Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for gtest_vendor package #1516

Closed
1 task
dkroenke opened this issue Jul 18, 2022 · 0 comments · Fixed by #1688
Closed
1 task

Support for gtest_vendor package #1516

dkroenke opened this issue Jul 18, 2022 · 0 comments · Fixed by #1688
Assignees
@dkroenke
Labels
tooling All iceoryx related tooling (scripts etc.)

Comments

@dkroenke
Copy link
Member

Brief feature description

When building tests in iceoryx, it checks if a GTest package was found and if not it will be build by our own via an ExternalProject in CMake. For a better support on ROS 2, we should add a support for vendor packages for GTest and GMock that are provided by frameworks like ROS 2.

See: https://github.com/ament/googletest/blob/rolling/googletest/package.xml

Detailed information

  • Try to detect if a gtest vendor package and use this if present instead of the own built GTtest in CMake
@dkroenke dkroenke added the tooling All iceoryx related tooling (scripts etc.) label Jul 18, 2022
@dkroenke dkroenke self-assigned this Jul 18, 2022
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 18, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Remove unnecessary CMake code
f9754b6 
Signed-off-by: Dietrich Kroenke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 18, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Add support for gtest_vendor package
7ae6220 
Restructure iceoryx_posh_testing into own CMake file

Signed-off-by: Dietrich Kroenke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 18, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use BUILD_TESTING instead of BUILD_TEST in C…
d3af66a 
…Make

Signed-off-by: Dietrich Kroenke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 19, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use GTest detection in own cmake macro
d0a48ee 
Write a central macro used by other libraries to
detect if GTest or gtest_vendor package is present
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 19, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use BUILD_TESTING for building tests
520c54d
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 19, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Remove unnecessary CMake code
1c0703c 
Signed-off-by: Dietrich Kroenke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 19, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use GTest detection in own cmake macro
9d355e7 
Write a central macro used by other libraries to
detect if GTest or gtest_vendor package is present
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 19, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use BUILD_TESTING for building tests
89abfc4
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 19, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Remove unnecessary CMake code
b114837 
Signed-off-by: Dietrich Kroenke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 19, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use GTest detection in own cmake macro
5cb7976 
Write a central macro used by other libraries to
detect if GTest or gtest_vendor package is present

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 19, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use BUILD_TESTING for building tests
73b38b7 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 20, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Remove unnecessary CMake code
dd8ba60 
Signed-off-by: Dietrich Kroenke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 20, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use GTest detection in own cmake macro
0ad8e88 
Write a central macro used by other libraries to
detect if GTest or gtest_vendor package is present

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Jul 20, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use BUILD_TESTING for building tests
3df04b0 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 1, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Add gtest/gmock ament packages as package de…
f475f85 
…pendency

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 1, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Remove CXX standard from C examples
442676c 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 1, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Move posh testing lib into own CMake file
f36fe6c 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 1, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Add CMake function for gtest detection in hoofs
fb8978b 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 1, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use BUILD_TESTING as CMake flag
3a5b8ff 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Add gtest/gmock ament packages as package de…
390fcc8 
…pendency

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Remove CXX standard from C examples
96bdec0 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Move posh testing lib into own CMake file
a5d72f1 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Add CMake function for gtest detection in hoofs
d7bbc05 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use Googletest detection in all components
023db8e 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use Googletest detection in all components
0fb3b51 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 3, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Use Googletest detection in all components
88cebe7 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Doc cmake args for library in hoofs_testing
d633a49
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Disable sign-compare in TEST_CXX_FLAGS
f346bfe
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Aug 4, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Disable Wsign-compare warning tests
42b5486
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Sep 28, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Refactor iceoryx_posh testing lib into own C…
969ec84 
…Make file

Signed-off-by: Dietrich Kroenke <[email protected]>
@dkroenke dkroenke mentioned this issue Sep 28, 2022
Merged
22 tasks
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Oct 24, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Refactor iceoryx_posh_testing into own CMake…
3b81058 
… file

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Oct 24, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Refactor iceoryx_posh_testing into own CMake…
4c416a2 
… file

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Refactor iceoryx_posh_testing into own CMake…
03b4e9e 
… file

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Oct 25, 2022
@dkroenke
iox-eclipse-iceoryx#1516 Prevent copyback on freebsd CI job
a72c6a8 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit that referenced this issue Oct 26, 2022
@dkroenke
Merge pull request #1688 from ApexAI/iox-1516-rework-iceoryx-posh-tes…
96aec4d 
…ting-cmake

iox-#1516 Refactor iceoryx_posh testing lib into own CMake file
mossmaurice pushed a commit that referenced this issue Jan 17, 2023
@dkroenke @mossmaurice
iox-#1516 Prevent copyback on freebsd CI job
afc4647 
Signed-off-by: Dietrich Krönke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkroenke dkroenke

Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iox-#1516 Refactor iceoryx_posh testing lib into own CMake file ApexAI/iceoryx
1 participant
@dkroenke