Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericRAII stores only a reference to cleanup function and renamed to ScopeGuard #1450

Closed
MatthiasKillat opened this issue Jul 5, 2022 · 2 comments · Fixed by #1585
Closed

GenericRAII stores only a reference to cleanup function and renamed to ScopeGuard #1450

MatthiasKillat opened this issue Jul 5, 2022 · 2 comments · Fixed by #1585
Assignees
@MatthiasKillat
Labels
refactoring Refactor code without adding features

Comments

@MatthiasKillat
Copy link
Contributor

MatthiasKillat commented Jul 5, 2022 •
edited
Loading

Refactoring

  1. Pass a cleanup function as function_ref instead of function (but store as function as is).
  2. Rename into ScopeGuard

cf. https://stackoverflow.com/questions/31365013/what-is-scopeguard-in-c
@MatthiasKillat MatthiasKillat added the bug Something isn't working label Jul 5, 2022
@MatthiasKillat MatthiasKillat self-assigned this Jul 5, 2022
@MatthiasKillat MatthiasKillat mentioned this issue Jul 5, 2022
Merged
21 tasks
@MatthiasKillat
Copy link
Contributor Author

Actually the cleanup function is correct on master (and a cxx function). We should still consider renaming GenericRAII to ScopeGuard.

@MatthiasKillat MatthiasKillat added refactoring Refactor code without adding features and removed bug Something isn't working labels Jul 6, 2022
@elBoberido
Copy link
Member

@MatthiasKillat yes, the ScopeGuard terminology is already used by the C++ community

mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Aug 22, 2022
@mossmaurice
iox-eclipse-iceoryx#1450 Rename GenericRAII to ScopeGuard
13565f2 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Aug 22, 2022
@mossmaurice
iox-eclipse-iceoryx#1450 Add release note entry for renaming of Gener…
c1e89fa 
…icRAII

Signed-off-by: Simon Hoinkis <[email protected]>
@mossmaurice mossmaurice changed the title GenericRAII stores only a reference to cleanup function GenericRAII stores only a reference to cleanup function and renamed to ScopeGuard Aug 22, 2022
@mossmaurice mossmaurice mentioned this issue Aug 22, 2022
Merged
21 tasks
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Aug 22, 2022
@mossmaurice
iox-eclipse-iceoryx#1450 Add release note entry for renaming of Gener…
8db7fe1 
…icRAII

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Aug 22, 2022
@mossmaurice
iox-eclipse-iceoryx#1450 Rename GenericRAII to ScopeGuard
872b401 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Aug 22, 2022
@mossmaurice
iox-eclipse-iceoryx#1450 Add release note entry for renaming of Gener…
bcde3d2 
…icRAII

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Aug 23, 2022
@mossmaurice
iox-eclipse-iceoryx#1450 Rename GenericRAII to ScopeGuard
b5b302c 
Signed-off-by: Simon Hoinkis <[email protected]>

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Aug 23, 2022
@mossmaurice
iox-eclipse-iceoryx#1450 Add release note entry for renaming of Gener…
99f030b 
…icRAII

Signed-off-by: Simon Hoinkis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthiasKillat MatthiasKillat

Labels
refactoring Refactor code without adding features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iox-#1450 Rename GenericRAII to ScopeGuard ApexAI/iceoryx
2 participants
@elBoberido @MatthiasKillat