-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Logger #1345
Comments
@elBoberido What do you think about dividing this issue in multiple sub issues? This issue is kept to keep track of the overall feature progress and every task gets its own issue which is linked in the task todo list here. Then we can manage discussions at the right place and prevent comment cluttering in the main issue. Then we also would easy the problem of closing the issue when a PR is merged. |
@elfenpiff I'm a bit torn on this. For me the design document, implementation and tests belong together in one issue. Integration might be a different issue. The question is also how this is handled when someone does not use subtasks? Is this person then not allowed to have multiple PRs for the same issue? Do we enforce to have subtasks? What happens when someone notices that it might be better to split the implementation in multiple PRs after the implementation started? What happens when the implementation started with a small refactoring and the it turned out to make sense to have the refactoring as separate PR? There is in general also not much discussions going on in the issue itself but on the PRs. From my point of view the only problem this would solve is that issues are closed when a PR is merged. Everything else should be handled by the developer working on the feature and as little as possible should be enforced. Regarding this feature, I'd like to have the design document, implementation and tests on the same issue. The remaining tasks shouldn't could then be moved to a separate issue but currently I don't feel that it would improve my workflow or save me time and it also does not have a negative impact on the reviewer. |
…nary when minimal log level is OFF
…-object-when-logging-is-off iox-#1345 do not create logstream object when logging is off
…or remaining logger todos
iox-#1345 Design document for logging
Brief feature description
Log messages cannot be forwarded to another logging framework. To make this possible, the logger must be refactored.
Detailed information
When iceoryx is used with another framework it is not possible to forward log messages to the native logger of the framework.
The logger shall be refactored to be able to to switch the backend at compile time or at runtime.
Tasks
The text was updated successfully, but these errors were encountered: