Skip to content

Commit

Permalink
iox-#1032 Remove 'noexcept' from overrides
Browse files Browse the repository at this point in the history
  • Loading branch information
elBoberido committed Jan 9, 2024
1 parent 21288b8 commit 82c9545
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,19 @@ TestingErrorHandler::TestingErrorHandler() noexcept
{
}

void TestingErrorHandler::onPanic() noexcept
void TestingErrorHandler::onPanic()
{
m_panicked = true;
jump();
}

void TestingErrorHandler::onReportError(er::ErrorDescriptor desc) noexcept
void TestingErrorHandler::onReportError(er::ErrorDescriptor desc)
{
std::lock_guard<std::mutex> g(m_mutex);
m_errors.push_back(desc);
}

void TestingErrorHandler::onReportViolation(er::ErrorDescriptor desc) noexcept
void TestingErrorHandler::onReportViolation(er::ErrorDescriptor desc)
{
std::lock_guard<std::mutex> g(m_mutex);
m_violations.push_back(desc);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ class TestingErrorHandler : public iox::er::ErrorHandlerInterface
static void init() noexcept;

/// @brief Defines the reaction on panic.
void onPanic() noexcept override;
void onPanic() override;

/// @brief Defines the reaction on error.
/// @param desc error descriptor
void onReportError(er::ErrorDescriptor desc) noexcept override;
void onReportError(er::ErrorDescriptor desc) override;

/// @brief Defines the reaction on violation.
/// @param desc error descriptor
void onReportViolation(er::ErrorDescriptor desc) noexcept override;
void onReportViolation(er::ErrorDescriptor desc) override;

/// @brief Indicates whether there was a panic call previously.
/// @return true if there was a panic call, false otherwise
Expand Down

0 comments on commit 82c9545

Please sign in to comment.