Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fast DDS CI job #12

Merged

Conversation

SchwarzeMagier
Copy link
Contributor

Pre-Review Checklist for the PR Author

  1. Code is formatted with clang-format
  2. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  3. Relevant issues are linked
  4. Add sensible notes for the reviewer
  5. All checks have passed
  6. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SchwarzeMagier LGTM, thanks for the PR! Two small nitpicks.

README.md Outdated Show resolved Hide resolved
cmake/fastdds/fastdds.cmake.in Outdated Show resolved Hide resolved
@mossmaurice mossmaurice added the enhancement New feature or request label Jan 28, 2025
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SchwarzeMagier
Copy link
Contributor Author

Hi, @elBoberido @mossmaurice Thank you for your suggestions. I have made the modifications to these parts. Could you please help me check them again? Thank you!

Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. LGTM.

@elBoberido elBoberido merged commit fead82b into eclipse-iceoryx:main Jan 29, 2025
4 checks passed
@SchwarzeMagier SchwarzeMagier deleted the iox-dds-add-fastdds-ci branch January 29, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants