-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3190] Use OpenTelemetry for tracing (via OpenTracing shim) #3205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove the reference to Jaeger Client, Apache Thrift and all of its dependencies (if no longer used by other components) from the legal/src/main/resources/legal/NOTICE.md file
service-base/src/main/java/org/eclipse/hono/service/quarkus/OpenTelemetryProducer.java
Outdated
Show resolved
Hide resolved
service-base/src/main/java/org/eclipse/hono/service/quarkus/SamplerProducer.java
Show resolved
Hide resolved
core/src/test/java/org/eclipse/hono/tracing/MultiMapInjectExtractAdapterTest.java
Show resolved
Hide resolved
core/src/test/java/org/eclipse/hono/tracing/JsonObjectInjectExtractAdapterTest.java
Show resolved
Hide resolved
...rc/test/java/org/eclipse/hono/client/kafka/tracing/KafkaHeadersInjectExtractAdapterTest.java
Show resolved
Hide resolved
...rtx-base/src/test/java/org/eclipse/hono/adapter/coap/CoapOptionInjectExtractAdapterTest.java
Outdated
Show resolved
Hide resolved
d8d8013
to
0949107
Compare
site/documentation/content/admin-guide/monitoring-tracing-config.md
Outdated
Show resolved
Hide resolved
tests/src/test/java/org/eclipse/hono/tests/DownstreamMessageAssertions.java
Outdated
Show resolved
Hide resolved
…im). Signed-off-by: Carsten Lohmann <[email protected]>
0949107
to
7e03993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is for #3190.
OpenTelemetry is now used for tracing via OpenTracing shim. Traces get exported via the OTLP gRPC Exporter (
quarkus-opentelemetry-exporter-otlp
). Support for Jaeger context propagation has been kept.Limitations:
Still to be done:
clarify "org.jboss.spec.javax.ws.rs/jboss-jaxrs-api_2.1_spec/2.0.1.Final" license entry (currently marked as restricted)documentation changes