Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Server*Action to StatusAction and MessageAction #1071

Closed
ndoschek opened this issue Jul 24, 2023 · 0 comments
Closed

Rename Server*Action to StatusAction and MessageAction #1071

ndoschek opened this issue Jul 24, 2023 · 0 comments
Assignees
@tortmayr
Labels
enhancement New feature or request
Milestone
2.0.0 Release (Op...

Comments

@ndoschek
Copy link
Contributor

Offtopic: Dispatching ServerStatusActions or ServerMessageActions on the client side seems a bit weird.
In general, these actions are just plain status or message notifications and don't have to necessarily come from the server. Maybe we should consider a rename here to a more generic StatusAction and MessageAction or at the very least make it clear in the documentation that this actions can also be dispatched from the client side.

Originally posted by @tortmayr in eclipse-glsp/glsp-client#269 (comment)
@ndoschek ndoschek added the enhancement New feature or request label Jul 24, 2023
@ndoschek ndoschek mentioned this issue Jul 24, 2023
Merged
@planger planger added this to the 2.0.0 Release (Optional) milestone Jul 27, 2023
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Sep 14, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
f0b33a9 
Part of eclipse-glsp/glsp#1071
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Sep 14, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
ad910dc 
Also remove unused `ServerStatus` class
Part of eclipse-glsp/glsp#1071
This was referenced Sep 14, 2023
Merged
Merged
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Sep 14, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
e0c46f1 
Part of eclipse-glsp/glsp/issues/1071
@tortmayr tortmayr mentioned this issue Sep 14, 2023
Merged
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Sep 14, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
efa7901 
Also remove unused `ServerStatus` class
Part of eclipse-glsp/glsp#1071
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Sep 14, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
51393a5 
Also remove unused `ServerStatus` class
Part of eclipse-glsp/glsp#1071
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Sep 15, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
7c28e42 
Also remove unused `ServerStatus` class
Part of eclipse-glsp/glsp#1071
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Sep 15, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
d3439e7 
Also remove unused `ServerStatus` class
Part of eclipse-glsp/glsp#1071
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Sep 15, 2023
@tortmayr
Adapt to latest protocol changes
f5c606c 
# GLSP-1116 Revise model loading
- Refactor `ModelSubmissionHandler` to support proper handling of the `RequestModelAction`
as real request action 
Part-of: eclipse-glsp/glsp#1116

# GLSP-1117: Remove need for explicit definition of client actions

Refactor the base GLSP protocol to allow the client to tell the server which actions it is going to handle i.e. which actions should be forwarded to the client
- Add `clientActions` array to `InitializeClientSessionParams`. This means the client now has to pass the action kinds it wants to handle as part of the initalize request
- Replace `ClientActionHandler` with `ClientActionForwader` a separate component that is not part of the server-side action handlers. 
- Remove `configureClientActions` method from `DiagramModule` as the explicit configuration is no longer needed

Part of eclipse-glsp/glsp/issues/1117

#GLSP-1071: Rename ServerStatus/ServerMessage action
Part of eclipse-glsp/glsp/issues/1071
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Sep 15, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
1323e76 
Also remove unused `ServerStatus` class
Part of eclipse-glsp/glsp#1071
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Sep 15, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
80f0129 
Part of eclipse-glsp/glsp#1071
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Sep 15, 2023
@tortmayr
GLSP-1116 Revise model loading (#287)
42b06df 
* GLSP-1116 Revise model loading

- Refactor diagram loader
   - Remove dispatching of temporary empty set model action and instead call `actionDispatcher.initialize()`   earlier which also dispatches an empty set model action under the hood  
   - Add additional `postModelInitalization` hook for startup services that want execute logic after the model is fully initialized
- Rework `ModelInitializationConstraint`
   - Provide `onInitialized` override that allows sync registration of listener callbacks
   - Refactor `setCompleted` method and remove the possiblity to set the initialized state to false.
     Model initialization is a one-time action. Once initialized there should be no way to "uninitialize" the constraint
   - Provide test cases
- Add `dispatchOnceModelInitialized` utility function to action dispatcher
- Ensure that type hints are  requested after the model has been initialized

Part-of: eclipse-glsp/glsp#1116
Part-of: eclipse-glsp/glsp#606

* GLSP-1117: Remove need for explicit definition of client actions

-Extend `initializeClientSession` request to also specific the set of client action kinds. This way the server knows which actions should be sent to the client
-Adapt `GLSPModelSource´ to retrieve the client actions before sending the `initializeClientSession` request
- Add customized `GLSPActionHandlerRegistry` which provides a query method to retrieve all handled action kinds

Part of eclipse-glsp/glsp/issues/1117

* GLSP-1071: Rename ServerStatus/ServerMessage action

Part of eclipse-glsp/glsp#1071
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Sep 15, 2023
@tortmayr
Adapt to latest protocol changes
f176d05 
# GLSP-1116 Revise model loading
- Refactor `ModelSubmissionHandler` to support proper handling of the `RequestModelAction`
as real request action 
Part-of: eclipse-glsp/glsp#1116

# GLSP-1117: Remove need for explicit definition of client actions

Refactor the base GLSP protocol to allow the client to tell the server which actions it is going to handle i.e. which actions should be forwarded to the client
- Add `clientActions` array to `InitializeClientSessionParams`. This means the client now has to pass the action kinds it wants to handle as part of the initalize request
- Replace `ClientActionHandler` with `ClientActionForwader` a separate component that is not part of the server-side action handlers. 
- Remove `configureClientActions` method from `DiagramModule` as the explicit configuration is no longer needed

Part of eclipse-glsp/glsp/issues/1117

#GLSP-1071: Rename ServerStatus/ServerMessage action
Part of eclipse-glsp/glsp/issues/1071
@tortmayr tortmayr mentioned this issue Sep 15, 2023
Merged
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Sep 18, 2023
@tortmayr
Adapt to latest protocol changes (#57)
b17a86c 
# GLSP-1116 Revise model loading
- Refactor `ModelSubmissionHandler` to support proper handling of the `RequestModelAction`
as real request action 
Part-of: eclipse-glsp/glsp#1116

# GLSP-1117: Remove need for explicit definition of client actions

Refactor the base GLSP protocol to allow the client to tell the server which actions it is going to handle i.e. which actions should be forwarded to the client
- Add `clientActions` array to `InitializeClientSessionParams`. This means the client now has to pass the action kinds it wants to handle as part of the initalize request
- Replace `ClientActionHandler` with `ClientActionForwader` a separate component that is not part of the server-side action handlers. 
- Remove `configureClientActions` method from `DiagramModule` as the explicit configuration is no longer needed

Part of eclipse-glsp/glsp/issues/1117

#GLSP-1071: Rename ServerStatus/ServerMessage action
Part of eclipse-glsp/glsp/issues/1071
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Sep 20, 2023
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
8a10ed4 
Part of eclipse-glsp/glsp/issues/1071
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Sep 20, 2023
@tortmayr
GLSP-1116 Revise model loading (#178)
6608c4f 
* GLSP-1116 Revise model loading

Adapt codebase to client changes for eclipse-glsp/glsp/issues/1116

* GLSP-1071: Rename ServerStatus/ServerMessage action

Part of eclipse-glsp/glsp/issues/1071
@tortmayr tortmayr self-assigned this Sep 20, 2023
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@tortmayr @holkerveen
GLSP-1116 Revise model loading (eclipse-glsp#287)
c0e6a7d 
* GLSP-1116 Revise model loading

- Refactor diagram loader
   - Remove dispatching of temporary empty set model action and instead call `actionDispatcher.initialize()`   earlier which also dispatches an empty set model action under the hood  
   - Add additional `postModelInitalization` hook for startup services that want execute logic after the model is fully initialized
- Rework `ModelInitializationConstraint`
   - Provide `onInitialized` override that allows sync registration of listener callbacks
   - Refactor `setCompleted` method and remove the possiblity to set the initialized state to false.
     Model initialization is a one-time action. Once initialized there should be no way to "uninitialize" the constraint
   - Provide test cases
- Add `dispatchOnceModelInitialized` utility function to action dispatcher
- Ensure that type hints are  requested after the model has been initialized

Part-of: eclipse-glsp/glsp#1116
Part-of: eclipse-glsp/glsp#606

* GLSP-1117: Remove need for explicit definition of client actions

-Extend `initializeClientSession` request to also specific the set of client action kinds. This way the server knows which actions should be sent to the client
-Adapt `GLSPModelSource´ to retrieve the client actions before sending the `initializeClientSession` request
- Add customized `GLSPActionHandlerRegistry` which provides a query method to retrieve all handled action kinds

Part of eclipse-glsp/glsp/issues/1117

* GLSP-1071: Rename ServerStatus/ServerMessage action

Part of eclipse-glsp/glsp#1071
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@tortmayr @holkerveen
GLSP-1116 Revise model loading (eclipse-glsp#287)
a167f65 
* GLSP-1116 Revise model loading

- Refactor diagram loader
   - Remove dispatching of temporary empty set model action and instead call `actionDispatcher.initialize()`   earlier which also dispatches an empty set model action under the hood  
   - Add additional `postModelInitalization` hook for startup services that want execute logic after the model is fully initialized
- Rework `ModelInitializationConstraint`
   - Provide `onInitialized` override that allows sync registration of listener callbacks
   - Refactor `setCompleted` method and remove the possiblity to set the initialized state to false.
     Model initialization is a one-time action. Once initialized there should be no way to "uninitialize" the constraint
   - Provide test cases
- Add `dispatchOnceModelInitialized` utility function to action dispatcher
- Ensure that type hints are  requested after the model has been initialized

Part-of: eclipse-glsp/glsp#1116
Part-of: eclipse-glsp/glsp#606

* GLSP-1117: Remove need for explicit definition of client actions

-Extend `initializeClientSession` request to also specific the set of client action kinds. This way the server knows which actions should be sent to the client
-Adapt `GLSPModelSource´ to retrieve the client actions before sending the `initializeClientSession` request
- Add customized `GLSPActionHandlerRegistry` which provides a query method to retrieve all handled action kinds

Part of eclipse-glsp/glsp/issues/1117

* GLSP-1071: Rename ServerStatus/ServerMessage action

Part of eclipse-glsp/glsp#1071
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@tortmayr
GLSP-1071: Rename ServerStatus/ServerMessage action
c8389fa 
Also remove unused `ServerStatus` class
Part of eclipse-glsp/glsp#1071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0 Release (Optional)
Development

No branches or pull requests
3 participants
@planger @tortmayr @ndoschek