Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#191: Provide correct kind for SelectAction #98

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Conversation

martin-fleck-at
Copy link
Contributor

@martin-fleck-at
Copy link
Contributor Author

It is even correct in the PROTOCOL definition: https://github.com/eclipse-glsp/glsp/blob/master/PROTOCOL.md#2931-selectaction ;-)

Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@martin-fleck-at martin-fleck-at merged commit ff26192 into master Feb 15, 2021
@martin-fleck-at martin-fleck-at deleted the issues/191 branch February 15, 2021 14:12
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectAction provides wrong kind
3 participants