Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding max version requirements for guava to prevent version conflicts #202

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Adding max version requirements for guava to prevent version conflicts #202

merged 1 commit into from
Jul 4, 2023

Conversation

N1k145
Copy link
Contributor

@N1k145 N1k145 commented Jul 4, 2023

@planger planger self-requested a review July 4, 2023 07:26
planger
planger approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and congrats to your first contribution, looks good to me! 👍

@planger planger merged commit 7fd3954 into eclipse-glsp:master Jul 4, 2023
@N1k145 N1k145 deleted the issue/1046 branch July 4, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guava Version Binding
3 participants
@N1k145 @planger @tortmayr