GLSP-991: Switch Jenkins build to Java 17 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Remove direct dependency to javax.inject by switching to google.inject counterparts Due to the namespace switch from javax->jakarta with Java17 it's otherwise hard to maintain a build that works for both 11 and 17. -Remove `illegal-access=permit" flag from plugin configuration as it is no longer supported in Java17 -Update maven-shade plugin config to get rid of warnings -Introduce a new orthogonal Java11 compatibility build job that is triggered for every master commit Fixes eclipse-glsp/glsp#991
planger
approved these changes
May 8, 2023
MatthiasHofstaetter
pushed a commit
to MatthiasHofstaetter/glsp-server
that referenced
this pull request
Dec 21, 2024
-Remove direct dependency to javax.inject by switching to google.inject counterparts Due to the namespace switch from javax->jakarta with Java17 it's otherwise hard to maintain a build that works for both 11 and 17. -Remove `illegal-access=permit" flag from plugin configuration as it is no longer supported in Java17 -Update maven-shade plugin config to get rid of warnings -Introduce a new orthogonal Java11 compatibility build job that is triggered for every master commit Fixes eclipse-glsp/glsp#991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the namespace switch from javax->jakarta with Java17 it's otherwise hard to maintain a build that works for both 11 and 17.
Fixes eclipse-glsp/glsp#991