Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#487 Improve GLSP Server API documentation #146

Merged
merged 4 commits into from
Dec 22, 2021
Merged

#487 Improve GLSP Server API documentation #146

merged 4 commits into from
Dec 22, 2021

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Dec 21, 2021

Improve API documentation for service interfaces

Co-authored-by: Tobias Ortmayr [email protected]

Fixes eclipse-glsp/glsp#487

Contributed on behalf of STMicroelectronics

@ndoschek ndoschek requested a review from tortmayr December 21, 2021 09:26
@ndoschek ndoschek changed the title WIP API Doc #487 Improve GLSP Server API documentation Dec 21, 2021
@ndoschek ndoschek marked this pull request as ready for review December 21, 2021 14:20
- Improve API documentation for service interfaces

Co-authored-by: Tobias Ortmayr <[email protected]>

Contributed on behalf of STMicroelectronics
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. I only have a few minor suggestions linline.

@ndoschek
Copy link
Contributor Author

Thanks for your review Tobias, I added another commit that addresses your comments!

@tortmayr tortmayr merged commit 5212538 into eclipse-glsp:master Dec 22, 2021
@ndoschek ndoschek deleted the api-doc branch December 22, 2021 08:14
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
Improve API documentation for service interfaces

Fixed eclipse-glsp/issues/146

Co-authored-by: Tobias Ortmayr <[email protected]>

Contributed on behalf of STMicroelectronics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve GLSP Server API documentation
2 participants