-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#487 Improve GLSP Server API documentation #146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve API documentation for service interfaces Co-authored-by: Tobias Ortmayr <[email protected]> Contributed on behalf of STMicroelectronics
tortmayr
requested changes
Dec 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me. I only have a few minor suggestions linline.
plugins/org.eclipse.glsp.graph/src/org/eclipse/glsp/graph/GraphExtension.java
Outdated
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/ActionRegistry.java
Outdated
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/ActionRegistry.java
Outdated
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/ActionRegistry.java
Outdated
Show resolved
Hide resolved
...server/src/org/eclipse/glsp/server/features/commandpalette/CommandPaletteActionProvider.java
Outdated
Show resolved
Hide resolved
...ns/org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/popup/PopupModelFactory.java
Outdated
Show resolved
Hide resolved
...ns/org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/popup/PopupModelFactory.java
Outdated
Show resolved
Hide resolved
...ns/org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/popup/PopupModelFactory.java
Outdated
Show resolved
Hide resolved
...se.glsp.server/src/org/eclipse/glsp/server/features/toolpalette/ToolPaletteItemProvider.java
Outdated
Show resolved
Hide resolved
...s/org.eclipse.glsp.server/src/org/eclipse/glsp/server/operations/CreateOperationHandler.java
Outdated
Show resolved
Hide resolved
Thanks for your review Tobias, I added another commit that addresses your comments! |
MatthiasHofstaetter
pushed a commit
to MatthiasHofstaetter/glsp-server
that referenced
this pull request
Dec 21, 2024
Improve API documentation for service interfaces Fixed eclipse-glsp/issues/146 Co-authored-by: Tobias Ortmayr <[email protected]> Contributed on behalf of STMicroelectronics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve API documentation for service interfaces
Co-authored-by: Tobias Ortmayr [email protected]
Fixes eclipse-glsp/glsp#487
Contributed on behalf of STMicroelectronics