#95 Adapt example to conform to GLSPServerLauncher refactoring #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add launch configs for Eclipse Requires: eclipse-glsp/glsp-server/pull/69 Part of: eclipse-glsp/glsp#95
martin-fleck-at
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Change looks good to me, thank you Tobias! I just have some minor comments which you may address and the change might be updated if the server change is updated as well but overall it looks good and works well. Love the much better name of the launcher now and the shared launch configs!
|
|
||
| } catch (ParseException | IOException ex) { | ||
| System.out.println("Server start failed!"); | ||
| ex.printStackTrace(); |
There was a problem hiding this comment.
Is it on purpose that this is a mix of sys.err and sys.out? Cause you could print the stacktrace to sys.out as well by simply handing it in as a parameter.
|
|
||
| try { | ||
| CLIParser parser = new CLIParser(args, cliOptions, processName); | ||
| if (parser.optionExists("h")) { |
There was a problem hiding this comment.
Minor: Extract 'h' as constant or use from server change if available.
| public static void main(final String[] args) { | ||
| String processName = "WorkflowExampleGlspServer"; | ||
| Options cliOptions = CLIParser.getDefaultCLIOptions(); | ||
| cliOptions.addOption(new Option("w", "websocket", false, "Use websocket launcher instead of default")); |
There was a problem hiding this comment.
Minor: Extract 'w' as constant to avoid risk of rename-mismatches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add launch configs for Eclipse
Requires: eclipse-glsp/glsp-server/pull/69
Part of: eclipse-glsp/glsp#95