Support rendering of ghost element when creating elements #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce new element template module -- Adding new elements to the diagram based on templates -- Removing templates again - Support local bounds calculation for client-only added elements -- Must trigger RequestBounds for hidden view calculation -- Must not modify main view until ComputedBounds response is handled -- Mark ResizeHandles as not to be considered for bounds calculation -- Fix positioning of decorations for hidden view calculation - Add ghost element extension to tool palette -- Optional ghost element field in the trigger node creation action -- Ghost element is added as feedback to the mouse cursor -- If ghost element is dynamic, templates (palette items) are reloaded - Bonus: Re-calculate local bounds for resize behavior Fixes eclipse-glsp/glsp#1159
martin-fleck-at
force-pushed
the
issues/1159
branch
from
86c4644 to
f3444a3
Compare
tortmayr
requested changes
Nov 13, 2023
There was a problem hiding this comment.
In general the change works really well!
I have a couple of inline comments and suggestions but other than that everything looks good to me.
Could you please make sure that all of you newly introduced functions,classes etc. are added to the main index and that add (high level) jsdoc to them?
While marking the local-only RequestBounds/ComputedBounds as server actions works it is not really intuitive and rather confusing. I'm wondering whether we should add the a more generic approach here to explicitly restrict a specific action that is normally handle on both client and server to one target.
| @@ -35,3 +35,13 @@ export function isArgsAware(element: GModelElement): element is GModelElement & | |||
| export function hasArgs(element?: GModelElement): element is GModelElement & Required<ArgsAware> { | |||
| return element !== undefined && isArgsAware(element) && element.args !== undefined; | |||
| } | |||
|
|
|||
| export function ensureArgs(element?: GModelElement): element is GModelElement & Required<ArgsAware> { | |||
| if (element === undefined || !isArgsAware(element)) { | |||
There was a problem hiding this comment.
Minor: For reuse-ability it would be nicer if we move the undefined check into the isArgsAware function and make the element arg optional
packages/client/src/features/bounds/glsp-hidden-bounds-updater.ts
Outdated
Show resolved
Hide resolved
packages/client/src/features/bounds/glsp-hidden-bounds-updater.ts
Outdated
Show resolved
Hide resolved
packages/client/src/features/bounds/set-bounds-feedback-command.ts
Outdated
Show resolved
Hide resolved
Bonus: Simplify hidden bounds customization via CSS
tortmayr
requested changes
Nov 13, 2023
|
@tortmayr I agree that this would be a nice feature to have. However, currently there is no way to simply reload trigger actions and then to uniquely identify them so we can easily replace the action and template that we are currently using. So I pulled this out into an enhancement issue (eclipse-glsp/glsp#1161) as it would require more work that I want to consider out of scope for this ticket. What do you think? |
3 tasks
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
…sp#301) * Support rendering of ghost element when creating elements - Introduce new element template module -- Adding new elements to the diagram based on templates -- Removing templates again - Support local bounds calculation for client-only added elements -- Must trigger RequestBounds for hidden view calculation -- Must not modify main view until ComputedBounds response is handled -- Mark ResizeHandles as not to be considered for bounds calculation -- Fix positioning of decorations for hidden view calculation - Add ghost element extension to tool palette -- Optional ghost element field in the trigger node creation action -- Ghost element is added as feedback to the mouse cursor -- If ghost element is dynamic, templates (palette items) are reloaded - Bonus: Re-calculate local bounds for resize behavior Fixes eclipse-glsp/glsp#1159
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
…sp#301) * Support rendering of ghost element when creating elements - Introduce new element template module -- Adding new elements to the diagram based on templates -- Removing templates again - Support local bounds calculation for client-only added elements -- Must trigger RequestBounds for hidden view calculation -- Must not modify main view until ComputedBounds response is handled -- Mark ResizeHandles as not to be considered for bounds calculation -- Fix positioning of decorations for hidden view calculation - Add ghost element extension to tool palette -- Optional ghost element field in the trigger node creation action -- Ghost element is added as feedback to the mouse cursor -- If ghost element is dynamic, templates (palette items) are reloaded - Bonus: Re-calculate local bounds for resize behavior Fixes eclipse-glsp/glsp#1159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new element template module
-- Adding new elements to the diagram based on templates
-- Removing templates again
Support local bounds calculation for client-only added elements
-- Must trigger RequestBounds for hidden view calculation
-- Must not modify main view until ComputedBounds response is handled
-- Mark ResizeHandles as not to be considered for bounds calculation
-- Fix positioning of decorations for hidden view calculation
Add ghost element extension to tool palette
-- Optional ghost element field in the trigger node creation action
-- Ghost element is added as feedback to the mouse cursor
-- If ghost element is dynamic, templates (palette items) are reloaded
Bonus: Re-calculate local bounds for resize behavior
Fixes eclipse-glsp/glsp#1159
(Mouse cursor is also shown in the application but not on the video unfortunately)
Can be tested with eclipse-glsp/glsp-server-node#65