Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UI bundle #41

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

LuLeRoemer
Copy link
Contributor

This PR replaces the UI bundle and instead includes the public URL of the custom OMP Antora Default UI release.

This commit replaces the UI bundle and instead includes the public URL of the custom OMP Antora Default UI release.
@LuLeRoemer LuLeRoemer requested a review from bs-jokri June 29, 2021 15:01
Copy link
Contributor

@bs-jokri bs-jokri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -10,7 +10,7 @@ content:
tags: '*'
ui:
bundle:
url: ./src/docs/ui-bundle.zip
url: https://github.com/OpenManufacturingPlatform/sds-antora-ui/releases/download/v1.0.0/sds-antora-ui-bundle-1.0.0.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the URL looks really good. Nice path generated by GitHub

@bs-jokri bs-jokri merged commit dd342ee into eclipse-esmf:main Jun 30, 2021
@atextor atextor deleted the feature/replace-ui-bundle branch January 31, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants