Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model improvements for JAnnotationValue implementations #878

Closed
Tomas-Kraus opened this issue Feb 7, 2012 · 5 comments · Fixed by #1548
Closed

Model improvements for JAnnotationValue implementations #878

Tomas-Kraus opened this issue Feb 7, 2012 · 5 comments · Fixed by #1548
Assignees
@glassfishrobot
Labels
Component: xjc Priority: Major Type: Improvement

Comments

@Tomas-Kraus
Copy link
Member

Please consider for next API release:

  • class com.sun.codemodel.JAnnotationStringValue should be public
  • should be a getter for JAnnotationStringValue.value property
  • should be a getter for JAnnotationArrayMember.values property

Affected Versions

[2.2.5]
@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
Reported by dma_k

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
Was assigned to snajper

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
dma_k said:
Just noticed that JAnnotationArrayMember.values property is available via JAnnotationArrayMember.annotations() – so nothing to improve for this class.

Why not making JAnnotationUse.addValue(String name, JAnnotationValue annotationValue) public? Or another method to add JAnnotationValue to the collection of members is needed.

@Tomas-Kraus
Copy link
Member Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAXB-878

@Tomas-Kraus
Copy link
Member Author

lukasj added a commit to lukasj/jaxb-ri that referenced this issue May 11, 2021
@lukasj
update cm to src level 1.8,
c448eaa 
make JAnnotationStringValue public (eclipse-ee4j#878),
minor improvements in CM for better usage on SE 11+,add missing xjc export

Signed-off-by: Lukas Jungmann <[email protected]>
@lukasj lukasj mentioned this issue May 11, 2021
Merged
lukasj added a commit that referenced this issue May 11, 2021
@lukasj
update cm to src level 1.8,
6a529f4 
make JAnnotationStringValue public (#878),
minor improvements in CM for better usage on SE 11+,add missing xjc export

Signed-off-by: Lukas Jungmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glassfishrobot glassfishrobot

Labels
Component: xjc Priority: Major Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update cm to src level 1.8, lukasj/jaxb-ri
2 participants
@glassfishrobot @Tomas-Kraus