Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve HTTP admin login flow #25354

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Improve HTTP admin login flow #25354

merged 1 commit into from
Jan 27, 2025

Conversation

avpinchuk
Copy link
Contributor

@avpinchuk avpinchuk commented Jan 26, 2025 •
edited
Loading

Change REST admin login sequence:

  • Firstly, reject remote login if secure admin is disabled. This eliminates unnecessary trip to the login module.
  • Secondly, reuse admin token if any.
  • Try to login using login module as a last step.

@avpinchuk
Improve HTTP admin login flow
0bcf09a 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk avpinchuk self-assigned this Jan 26, 2025
@avpinchuk avpinchuk added security fix The change (component upgrade or gf code) concerns a CVE code cleaning labels Jan 26, 2025
@avpinchuk avpinchuk added this to the 7.0.22 milestone Jan 26, 2025
@avpinchuk avpinchuk marked this pull request as ready for review January 26, 2025 21:25
@arjantijms arjantijms merged commit f87ba31 into eclipse-ee4j:master Jan 27, 2025
3 checks passed
@avpinchuk avpinchuk deleted the admin-login branch January 27, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OndroMih OndroMih OndroMih approved these changes

@hs536 hs536 hs536 approved these changes

@dmatej dmatej Awaiting requested review from dmatej

@arjantijms arjantijms Awaiting requested review from arjantijms

@pzygielo pzygielo Awaiting requested review from pzygielo

Assignees

@avpinchuk avpinchuk

Labels
code cleaning security fix The change (component upgrade or gf code) concerns a CVE
Projects
None yet
Milestone
7.0.22
Development

Successfully merging this pull request may close these issues.
4 participants
@avpinchuk @OndroMih @hs536 @arjantijms