Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] NPE in QueryBasedValueHolder due to #2181 - bugfix #2330

Conversation

rfelcman
Copy link
Contributor

@rfelcman rfelcman commented Dec 17, 2024

Fixes #2317
There is regression bug introduced in #2181 . Scope of new ReentrantLock variable instanceLock was in case of new object instances created by clone() method across all cloned instances instead of one instanceLock per each instance.
In case of UnitOfWorkValueHolder incorrect lock was used wrappedValueHolderLock vs wrappedValueHolder.getInstanceLock()

Copy link
Member

@Tomas-Kraus Tomas-Kraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rfelcman rfelcman merged commit cd067c2 into eclipse-ee4j:4.0 Dec 18, 2024
3 checks passed
@rfelcman rfelcman deleted the bug_jpa_2317_npe_in_querybasedvalueholder_4.0 branch December 19, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants