[4.0] DatasourceAccessor ReentrantLock fix plus new SpringBoot test #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radek Felcman <[email protected]>
rfelcman
deleted the
bug_jpa_2219_could_not_open_jpa_entitymanager_4.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2219
Issue with
DatasourceAccessorReentratLockwhich was after migration accidentally shared acrossDatasourceAccessorinstances as new instances are in some cases created due aclone()method and not bynew DatasourceAccessor().There is new Spring Boot test module with HikariCP Datasource as this issue was discovered in this environment, but this initial test doesn't cover mentioned bug scenario due a missing information from customer.
Update in booth Spring test modules to execute them in CI environment.