[master] ClassWeaver refresh #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains following main changes: - Replacement of deprecated e.g. new Integer(...) by Integer.valueOf(...) - Generated _persistence_shallow_clone content is wrapped by try/catch - Remove dependency to JPA module (org.eclipse.persistence.internal.jpa.EntityManagerImpl class) in generated _persistence_checkFetched and _persistence_checkFetchedForSet There are some extensions in weaving test to more deeply check methods/logic generated by ClassWeaver. Signed-off-by: Radek Felcman <[email protected]>
lukasj
reviewed
Jan 26, 2024
| cv_checkFetched.visitJumpInsn(Opcodes.valueInt("IFNE"), l1); | ||
| // String errorMsg = _persistence_getFetchGroup(). | ||
| cv_checkFetched.visitVarInsn(Opcodes.valueInt("ALOAD"), 0); | ||
| cv_checkFetched.visitMethodInsn(Opcodes.valueInt("INVOKEVIRTUAL"), classDetails.getClassName(), "_persistence_getFetchGroup", "()Lorg/eclipse/persistence/queries/FetchGroup;", false); |
There was a problem hiding this comment.
reuse existing constants defined within this class, such as FETCHGROUP_SHORT_SIGNATURE in this case
…TestSuite.testBadGetReference test fix Signed-off-by: Radek Felcman <[email protected]>
Signed-off-by: Radek Felcman <[email protected]>
lukasj
reviewed
Jan 30, 2024
jpa/eclipselink.jpa.testapps/jpa.test.weaving/src/main/resources/META-INF/persistence.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Radek Felcman <[email protected]>
lukasj
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains following main changes:
new Integer(...)byInteger.valueOf(...)_persistence_shallow_clonecontent is wrapped bytry/catchorg.eclipse.persistence.internal.jpa.EntityManagerImplclass) in generated_persistence_checkFetchedand_persistence_checkFetchedForSetThere are some extensions in weaving test to more deeply check methods/logic generated by ClassWeaver.
To verify generated code I'd like recommend in extension to decompiler to use some plugin which can display decompiled bytecode as ASMified code. E.g. ASM Bytecode Viewer in InteliJ. Reason is that
Integer.valueOf(...)is not displayed in decompiled bytecode.