Integrate AWS IAM Role-based Authentication for MongoDB Atlas #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hu-ahmed
force-pushed
the
add-mongo-aws-iam-support
branch
from
321c7e2 to
d8705dc
Compare
thjaeckle
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Hi @hu-ahmed
Thanks a lot for this contribution.
You should mention in the PR that this is about Passwordless authentication of MongoDB with AWS IAM
The build contains a test error:
Error: Failures:
Error: DefaultOptionsConfigTest.testHashCodeAndEquals:63 EqualsVerifier found a problem in class org.eclipse.ditto.internal.utils.persistence.mongo.config.DefaultOptionsConfig.
-> Significant fields: equals does not use useAwsIamRole, or it is stateless.
And when updating the Helm chart, please update the Chart version - there is a linting in place which verifies that.
I added some inline comments, please check them.
...nce/src/main/java/org/eclipse/ditto/internal/utils/persistence/mongo/MongoClientWrapper.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/eclipse/ditto/internal/utils/persistence/mongo/config/MongoDbConfig.java
Show resolved
Hide resolved
...nce/src/main/java/org/eclipse/ditto/internal/utils/persistence/mongo/MongoClientWrapper.java
Outdated
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
hu-ahmed
changed the title
thjaeckle
reviewed
Jul 23, 2024
thjaeckle
reviewed
Jul 23, 2024
thjaeckle
approved these changes
Jul 23, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the integration of AWS IAM Role-based authentication for MongoDB Atlas in our application (Passwordless authentication of MongoDB with AWS IAM). By leveraging the AWS SDK's DefaultCredentialsProvider, we ensure secure and seamless authentication to MongoDB Atlas using the IAM role associated with the Kubernetes service account. The environment variables set by the service account are utilized to fetch the necessary credentials dynamically within the application. This implementation enhances security by eliminating the need for hardcoded credentials and leverages AWS's robust IAM policies for access control.