Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1946 fix that alternative OIDC provider for "devops" authorization could not be configured #1948

Conversation

thjaeckle
Copy link
Member

@thjaeckle thjaeckle commented May 29, 2024

  • improved logging correlationId also for devops auth in gateway as well

Resolves: #1946

@thjaeckle thjaeckle added the bug label May 29, 2024
@thjaeckle thjaeckle added this to the 3.5.7 milestone May 29, 2024
@thjaeckle thjaeckle self-assigned this May 29, 2024
…thorization could not be configured

* improved logging correlationId also for devops auth in gateway as well

Signed-off-by: Thomas Jäckle <[email protected]>
@thjaeckle thjaeckle force-pushed the fix-ditto-devops-oauth-subjects-config branch 7 times, most recently from 7fee1f7 to c428576 Compare May 31, 2024 07:55
…rectly with environment variable

Signed-off-by: Thomas Jäckle <[email protected]>
@thjaeckle thjaeckle force-pushed the fix-ditto-devops-oauth-subjects-config branch from c428576 to 4f07007 Compare May 31, 2024 09:32
@thjaeckle
Copy link
Member Author

@alstanchev @kalinkostashki if you could have a look, it would be great 👍

This issue happens when using oauth2 for securing devops access and wanting to configure a different OIDC provider than already configured for the "main" authentication with oauth2.

Copy link
Contributor

@kalinkostashki kalinkostashki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
and sorry for the delay :)

@thjaeckle thjaeckle merged commit 7bee1a5 into eclipse-ditto:master Jun 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
2 participants