UI small fixes and improvements #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- send message with timeout 0 showed incorrect error - added category column on connection logs - connections js editors had wron read-only behaviour - connection log details ace editor now with word wrap - Bug: filter on incoming messages Signed-off-by: thfries <[email protected]>
thjaeckle
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Thanks a lot @thfries
LGTM 👍
Btw.: is there a way to avoid that ditto transfers all HTTP headers into the ditto headers? The messages by default look polluted and with a lot of overhead in size.
Not by default, the "header passthrough" is a feature - you can however configure which headers to ignore and not "pass through" via Ditto service configuration.
I think this was the place:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @thjaeckle,
please find some small updates on the UI:
- send message with timeout 0 and no payload showed incorrect error in the response field. Reason was that on 202
response.json()was called that throwed an error. I added now 202 as "no content" case.- added category column on connection logs, so you can distinguish source and target log entries
- connections js editors had wrong read-only behavior
- connection log details ace editor now with word wrap, otherwise it is hard to read long message in one line. Btw.: is there a way to avoid that ditto transfers all HTTP headers into the ditto headers? The messages by default look polluted and with a lot of overhead in size.
- Bug: filter on incoming messages does not work on new incoming messages