Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1882 fixed ResolvedPolicyCacheLoader loading policy imports transitively #1883

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

thjaeckle
Copy link
Member

  • cause was that by recursively using the cache, also policy imports were resolved transitively
  • that could e.g. lead to a "PolicyLabelInvalidException" for scenarios with very nested policy import paths
  • in either case, it was breaking the not available transitiveness of policy imports

Fixes: #1882

…vely

* cause was that by recursively using the cache, also policy imports were resolved transitively
* that could e.g. lead to a "PolicyLabelInvalidException" for scenarios with very nested policy import paths
* in either case, it was breaking the not available transitiveness of policy imports
@thjaeckle thjaeckle added the bug label Jan 29, 2024
@thjaeckle thjaeckle added this to the 3.5.1 milestone Jan 29, 2024
@thjaeckle thjaeckle self-assigned this Jan 29, 2024
@thjaeckle
Copy link
Member Author

@alstanchev we found that today after our community call :/
Quite a blocker for running Ditto 3.5.0 - so a review would be highly welcome :D

Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle thjaeckle merged commit 569871f into master Jan 30, 2024
3 checks passed
kyberpunk pushed a commit to kyberpunk/ditto that referenced this pull request Feb 3, 2024
…-snippet

Necessary for the Ingress-Nginx Controller
kyberpunk pushed a commit to kyberpunk/ditto that referenced this pull request Feb 3, 2024
…proxy-headers-compromise

eclipse-ditto#1883 return pre-authenticated configuration to location-snippet
@thjaeckle thjaeckle deleted the bugfix/policy-imports-search branch February 26, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

When using Policy Imports, the Ditto search index might lose Data with Ditto 3.5.0
2 participants