Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect GDB problems already in launch config #178

Closed
Boereck opened this issue Nov 28, 2018 · 2 comments · Fixed by #285
Closed

Detect GDB problems already in launch config #178

Boereck opened this issue Nov 28, 2018 · 2 comments · Fixed by #285

Comments

@Boereck
Copy link
Contributor

Boereck commented Nov 28, 2018

Since in some cases, like #149, it would be beneficial if the GDB version would be detected already when the GDB location is entered. If errors occur, they can then be presented to the user already in the launch config to give users early and detailed feedback. The necessary functionality in CDT will be added with SimRel 2018-12 M3 (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=541520).

@anb0s
Copy link

anb0s commented Jan 13, 2019

2018-12 was released, this should work now ;) Thanks!

@mickaelistria
Copy link
Contributor

@anb0s do you confirm this is fixed and we can close it?

Boereck added a commit to Boereck/corrosion that referenced this issue Nov 22, 2019
…metic changes

Now the Rust debug launch config checks if the specified GDB is valid.
This is done in a blocking fashion, tests show that this does not block
the UI for an unreasonable time. Making the check non-blocking would
also make the code much more complicated, since the launcher framework
does not seem to be fit for such things.

Also some cosmetic changes were done to the debug launch config. The
"Main" tab now starts with a capital letter, as all other tabs. It also
has an icon now.
Boereck added a commit to Boereck/corrosion that referenced this issue Nov 22, 2019
…metic changes

Now the Rust debug launch config checks if the specified GDB is valid.
This is done in a blocking fashion, tests show that this does not block
the UI for an unreasonable time. Making the check non-blocking would
also make the code much more complicated, since the launcher framework
does not seem to be fit for such things.

Also some cosmetic changes were done to the debug launch config. The
"Main" tab now starts with a capital letter, as all other tabs. It also
has an icon now.

Signed-off-by: Max Bureck <[email protected]>
Boereck added a commit to Boereck/corrosion that referenced this issue Nov 22, 2019
…metic changes

Now the Rust debug launch config checks if the specified GDB is valid.
This is done in a blocking fashion, tests show that this does not block
the UI for an unreasonable time. Making the check non-blocking would
also make the code much more complicated, since the launcher framework
does not seem to be fit for such things.

Also some cosmetic changes were done to the debug launch config. The
"Main" tab now starts with a capital letter, as all other tabs. It also
has an icon now.

Signed-off-by: Max Bureck <[email protected]>
Boereck added a commit that referenced this issue Nov 22, 2019
Now the Rust debug launch config checks if the specified GDB is valid.
This is done in a blocking fashion, tests show that this does not block
the UI for an unreasonable time. Making the check non-blocking would
also make the code much more complicated, since the launcher framework
does not seem to be fit for such things.

Also some cosmetic changes were done to the debug launch config. The
"Main" tab now starts with a capital letter, as all other tabs. It also
has an icon now.

Signed-off-by: Max Bureck <[email protected]>
Boereck added a commit to Boereck/corrosion that referenced this issue Dec 8, 2019
…metic changes

Now the Rust debug launch config checks if the specified GDB is valid.
This is done in a blocking fashion, tests show that this does not block
the UI for an unreasonable time. Making the check non-blocking would
also make the code much more complicated, since the launcher framework
does not seem to be fit for such things.

Also some cosmetic changes were done to the debug launch config. The
"Main" tab now starts with a capital letter, as all other tabs. It also
has an icon now.

Signed-off-by: Max Bureck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants