Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementers is Broken for Class Files #10337 #11378

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

vrubezhny
Copy link
Contributor

Issue: #10337

Signed-off-by: Victor Rubezhny [email protected]

What does this PR do?

Fixes the Open Implementers functionality

What issues does this PR fix or reference?

Issue: #10337

Release Notes

ls10337

Docs PR

@riuvshin
Copy link
Contributor

Can one of the admins verify this patch?

2 similar comments
@riuvshin
Copy link
Contributor

Can one of the admins verify this patch?

@riuvshin
Copy link
Contributor

Can one of the admins verify this patch?

@benoitf benoitf added target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Sep 27, 2018
@svor svor requested a review from tsmaeder September 27, 2018 12:24
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however, it's a sign that we have a problem with uri's

@tsmaeder tsmaeder merged commit 43caa11 into eclipse-che:5730_java_ls_poc Sep 27, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 27, 2018
tsmaeder pushed a commit that referenced this pull request Oct 1, 2018
tsmaeder pushed a commit that referenced this pull request Oct 5, 2018
tsmaeder pushed a commit that referenced this pull request Oct 12, 2018
tsmaeder pushed a commit that referenced this pull request Oct 16, 2018
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants