-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementers is Broken for Class Files #10337 #11378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Rubezhny <[email protected]>
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
tsmaeder
reviewed
Sep 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, however, it's a sign that we have a problem with uri's
tsmaeder
approved these changes
Sep 27, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Oct 1, 2018
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 5, 2018
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 12, 2018
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 16, 2018
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Victor Rubezhny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Outline of a bug - must adhere to the bug report template.
target/branch
Indicates that a PR will be merged into a branch other than master.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10337
Signed-off-by: Victor Rubezhny [email protected]
What does this PR do?
Fixes the Open Implementers functionality
What issues does this PR fix or reference?
Issue: #10337
Release Notes
Docs PR