Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring ephemeral storage strategy in CheCluster #21885

Closed
AObuchow opened this issue Dec 13, 2022 · 6 comments
Closed

Allow configuring ephemeral storage strategy in CheCluster #21885

AObuchow opened this issue Dec 13, 2022 · 6 comments
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P2 Has a minor but important impact to the usage or development of the system. status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Milestone

Comments

@AObuchow
Copy link

AObuchow commented Dec 13, 2022

Is your enhancement related to a problem? Please describe

Currently it is not possible to configure the use of the Ephemeral storage strategy as the default storage strategy for Che workspaces through the Che Cluster CR.

Describe the solution you'd like

The Che Cluster CR devEnvironments.storage.pvcStrategy should allow for the ephemeral storage strategy.

The Dashboard already supports reading the configured storage type from the Che Cluster CR, and I believe there is already code in place that would allow support for the ephemeral storage strategy (I may be mistaken however).

Describe alternatives you've considered

Currently, it is only possible to use the ephemeral storage strategy on a per-workspace basis by changing the storage-type settings in the dashboard.
image

There is no way to set the ephemeral storage strategy to be used by all newly created workspaces.

Release Notes Text

It's now possible to specify ephemeral as the default storage strategy for every workspace through the CheCluster custom resource.

@AObuchow AObuchow added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 13, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 13, 2022
@dkwon17 dkwon17 added severity/P2 Has a minor but important impact to the usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 13, 2022
@ibuziuk ibuziuk mentioned this issue Dec 13, 2022
82 tasks
AObuchow added a commit to AObuchow/che-operator that referenced this issue Dec 13, 2022
@tolusha
Copy link
Contributor

tolusha commented Dec 14, 2022

Should be fixed by eclipse-che/che-operator#1580

@tolusha tolusha closed this as completed Dec 21, 2022
@tolusha tolusha added this to the 7.59 milestone Dec 21, 2022
@l0rd l0rd changed the title [Che-Operator] Support Ephemeral storage strategy in Che Cluster CR Allow configuring ephemeral storage strategy in CheCluster Jan 5, 2023
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jan 5, 2023
@l0rd
Copy link
Contributor

l0rd commented Jan 5, 2023

@AObuchow if you haven't yet can you double check if we need to update some documentation articles that mentions storage strategies?

@AObuchow
Copy link
Author

AObuchow commented Jan 5, 2023

@l0rd It seems the Che administration documentation needs to be updated to mention storage strategies: https://www.eclipse.org/che/docs/stable/administration-guide/configuring-storage/

Additionally, the section on configuring storage classes needs to be updated as well: it mentions that the Che Server is in charge of creating persistent volume claims (this is now handled by DWO), and also points to slightly outdated fields in the Che Cluster CR (devEnvironments.storage.pvc.storageClass instead of devEnvironments.storage.perWorkspaceStrategyPvcConfig.storageClass or devEnvironments.storage.perUserStrategyPvcConfig.storageClass)

I will work on a PR to update this section of the documentation. Let me know if there are any procedures I should follow or if there are members of the documentation team that I should contact, as this is my first time updating the Che Docs.

@max-cx
Copy link

max-cx commented Jan 12, 2023

ACK. Thank you for the PR to the docs repo, Andrew. A technical writer will self-assign it to review it toward RHDEVDOCS-4870.

@max-cx
Copy link

max-cx commented Apr 6, 2023

RN sync'd to Red Hat Jira https://issues.redhat.com/browse/CRW-4183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P2 Has a minor but important impact to the usage or development of the system. status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Projects
None yet
Development

No branches or pull requests

7 participants