-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide port redirect message for non public endpoints #17993
Comments
hello, is that 5005 endpoint is in the current devfile ? |
What do you mean with "current devfile"? If you mean the Quarkus devfile in the devfile registry then no, it's not there. If you mean if it's in the devfile I have used to reproduce this problem then yes. I have used the Quarkus devfile with the centos-quarkus-maven component with 2 endpoints instead of one: - name: hello-greeting-endpoint
port: 8080
attributes:
path: /hello/greeting/che-user
- name: quarkus-debug
port: 5005
attributes:
public: 'false' |
moving to |
- move modal dialogs to classic notification - add missing no option in redirect dialog - handle internal endpoints (private ports) - Add ports widget in addition to dialog popup of port plug-in - display public and private ports - allow to open in a new tab or preview url - filtering plugin's endpoints (default = true) Fixes eclipse-che/che#17972 Fixes eclipse-che/che#17993 Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac Signed-off-by: Florent Benoit <[email protected]>
- move modal dialogs to classic notification - add missing no option in redirect dialog - handle internal endpoints (private ports) - Add ports widget in addition to dialog popup of port plug-in - display public and private ports - allow to open in a new tab or preview url - filtering plugin's endpoints (default = true) Fixes eclipse-che/che#17972 Fixes eclipse-che/che#17993 Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac Signed-off-by: Florent Benoit <[email protected]>
- move modal dialogs to classic notification - add missing no option in redirect dialog - handle internal endpoints (private ports) - Add ports widget in addition to dialog popup of port plug-in - display public and private ports - allow to open in a new tab or preview url - filtering plugin's endpoints (default = true) Fixes eclipse-che/che#17972 Fixes eclipse-che/che#17993 Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac Signed-off-by: Florent Benoit <[email protected]>
- move modal dialogs to classic notification - add missing no option in redirect dialog - handle internal endpoints (private ports) - Add ports widget in addition to dialog popup of port plug-in - display public and private ports - allow to open in a new tab or preview url - filtering plugin's endpoints (default = true) Fixes eclipse-che/che#17972 Fixes eclipse-che/che#17993 Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac Signed-off-by: Florent Benoit <[email protected]>
- move modal dialogs to classic notification - add missing no option in redirect dialog - handle internal endpoints (private ports) - Add ports widget in addition to dialog popup of port plug-in - display public and private ports - allow to open in a new tab or preview url - filtering plugin's endpoints (default = true) Fixes eclipse-che/che#17972 Fixes eclipse-che/che#17993 Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac Signed-off-by: Florent Benoit <[email protected]>
- move modal dialogs to classic notification - add missing no option in redirect dialog - handle internal endpoints (private ports) - Add ports widget in addition to dialog popup of port plug-in - display public and private ports - allow to open in a new tab or preview url - filtering plugin's endpoints (default = true) Fixes eclipse-che/che#17972 Fixes eclipse-che/che#17993 Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac Signed-off-by: Florent Benoit <[email protected]>
- move modal dialogs to classic notification - add missing no option in redirect dialog - handle internal endpoints (private ports) - Add ports widget in addition to dialog popup of port plug-in - display public and private ports - allow to open in a new tab or preview url - filtering plugin's endpoints (default = true) Fixes eclipse-che/che#17972 Fixes eclipse-che/che#17993 Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac Signed-off-by: Florent Benoit <[email protected]>
- move modal dialogs to classic notification - add missing no option in redirect dialog - handle internal endpoints (private ports) - Add ports widget in addition to dialog popup of port plug-in - display public and private ports - allow to open in a new tab or preview url - filtering plugin's endpoints (default = true) Fixes eclipse-che/che#17972 Fixes eclipse-che/che#17993 Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac Signed-off-by: Florent Benoit <[email protected]>
- move modal dialogs to classic notification - add missing no option in redirect dialog - handle internal endpoints (private ports) - Add ports widget in addition to dialog popup of port plug-in - display public and private ports - allow to open in a new tab or preview url - filtering plugin's endpoints (default = true) Fixes eclipse-che/che#17972 Fixes eclipse-che/che#17993 Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac Signed-off-by: Florent Benoit <[email protected]>
Is your enhancement related to a problem? Please describe.
Currently devfiles allow to specify the endpoints of a workspace.
If the endpoint is NOT public no ingress should be created and the user should NOT be even prompted.
but we still ask the user if he wants to redirect the port
That's annoying (users need to click NO again and again) and frustrating (the spec in the devfile is ignored).
Describe the solution you'd like
Do not show the redirection prompt when
public: false
. We correctly avoid showing that same prompt whenpublic: true
because the ingress is always created. We should avoid showing it whenpublic: false
too because the ingress should never be created.The text was updated successfully, but these errors were encountered: