Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide port redirect message for non public endpoints #17993

Closed
l0rd opened this issue Sep 30, 2020 · 3 comments
Closed

Hide port redirect message for non public endpoints #17993

l0rd opened this issue Sep 30, 2020 · 3 comments
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Sep 30, 2020

Is your enhancement related to a problem? Please describe.

Currently devfiles allow to specify the endpoints of a workspace.

If the endpoint is NOT public no ingress should be created and the user should NOT be even prompted.

    endpoints:
      - name: quarkus-debug
        port: 5050
        attributes:
          public: false

but we still ask the user if he wants to redirect the port

image

That's annoying (users need to click NO again and again) and frustrating (the spec in the devfile is ignored).

Describe the solution you'd like

Do not show the redirection prompt when public: false. We correctly avoid showing that same prompt when public: true because the ingress is always created. We should avoid showing it when public: false too because the ingress should never be created.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 30, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 30, 2020
@benoitf
Copy link
Contributor

benoitf commented Sep 30, 2020

hello, is that 5005 endpoint is in the current devfile ?

@mmorhun mmorhun added status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 30, 2020
@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che and removed status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Sep 30, 2020
@l0rd
Copy link
Contributor Author

l0rd commented Sep 30, 2020

hello, is that 5005 endpoint is in the current devfile ?

What do you mean with "current devfile"?

If you mean the Quarkus devfile in the devfile registry then no, it's not there.

If you mean if it's in the devfile I have used to reproduce this problem then yes. I have used the Quarkus devfile with the centos-quarkus-maven component with 2 endpoints instead of one:

      - name: hello-greeting-endpoint
        port: 8080
        attributes:
          path: /hello/greeting/che-user
      - name: quarkus-debug
        port: 5005
        attributes:
          public: 'false'

@mmorhun mmorhun added the area/plugin-port Issues related to the port plugin label Sep 30, 2020
@azatsarynnyy azatsarynnyy added area/plugins and removed area/editor/theia Issues related to the che-theia IDE of Che area/plugin-port Issues related to the port plugin labels Sep 30, 2020
@azatsarynnyy
Copy link
Member

moving to area/plugins as the related functionality is in Ports Plugin

benoitf added a commit to benoitf/che-theia that referenced this issue Oct 12, 2020
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 12, 2020
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 19, 2020
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 23, 2020
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 26, 2020
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 27, 2020
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Nov 4, 2020
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
monaka pushed a commit to PizzaFactory/che-theia that referenced this issue Nov 4, 2020
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
monaka pushed a commit to PizzaFactory/che-theia that referenced this issue Nov 5, 2020
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants