Add a couple of default extensions

[vitaliy-guliy]

Signed-off-by: Vitaliy Gulyy [email protected]

What does this PR do?

Includes vscode.extension-editing and vscode.search-result extensions to list of default extensions.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#18282

How to test this PR?

Devfile to test changes (the extensions are injected to che-theia container as Che plugins)

---
apiVersion: 1.0.0
metadata:
  name: vscode-builtins
projects:
  -
    name: che-theia
    source:
      type: git
      location: "https://github.com/eclipse/che-theia.git"
  -
    name: vscode
    source:
      type: git
      location: "https://github.com/microsoft/vscode.git"
components:
  - type: cheEditor
    alias: che-theia
    id: eclipse/che-theia/latest
    memoryLimit: 2048M
  -
    type: chePlugin
    id: redhat/vscode-yaml/latest
  -
    type: chePlugin
    id: ms-vscode/node-debug2/latest
    preferences:
      debug.node.useV3: false
  -
    type: chePlugin
    alias: search-result
    reference: https://gist.githubusercontent.com/vitaliy-guliy/38e1b1d27d6370665357b625cd51f8d4/raw/d38a97e0d3006c6cd5043daacf389ec14ad3b371/meta.yaml
  -
    type: chePlugin
    alias: extension-editing
    reference: https://gist.githubusercontent.com/vitaliy-guliy/b7b93f099d88838b77ab309d9ec95648/raw/8895a43f46419932e097e7cc8b603f3b1d22c1bf/meta.yaml
  -
    type: chePlugin
    id: che-incubator/typescript/latest
    memoryLimit: 2048M
  -
    alias: che-dev
    type: dockerimage
    image: quay.io/eclipse/che-theia-dev:next
    memoryLimit: "3Gi"
    mountSources: true
    endpoints:
      - name: 'theia-dev-flow'
      # - name: 'che-theia-link'
        port: 3010
        attributes:
          type: ide-dev
          protocol: http
          public: 'true'
          discoverable: 'false'
commands:
  -
    name: '1.1 che-theia :: build'
    actions:
      - type: exec
        component: che-dev
        workdir: /projects/che-theia
        command: |
          yarn
          echo -e "\e[32mDone.\e[0m"

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job console

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	docker.io/maxura/che-theia:942
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:942

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[azatsarynnyy]

How I can verify these extensions are working?
What functionality do they contribute to Che Theia?

[benoitf]

for vscode extension editing
you can try with these files
https://github.com/microsoft/vscode/blob/7d57a8f6f546b5e30027e7cfa87bd834eb5c7bbb/extensions/extension-editing/package.json#L28-L48

[vitaliy-guliy]

For search-result you can perform searching, and then open a file. Found text should be highlighted.

[benoitf]

I don't have code completion in package.json when I edit a VS Code package.json

about search result, without this extension I already have some code highlights

[azatsarynnyy]

For search-result you can perform searching, and then open a file. Found text should be highlighted.

I see no difference comparing to che-theia:latest. I get the same result with and without vscode.search-result.

[azatsarynnyy]

When running a Workspace with

I get

update: the same error with the provided Devfile

[vitaliy-guliy]

When running a Workspace with

I get

update: the same error with the provided Devfile

Is your Che-Theia stable?
I never met this error.

Tested it with the latest Che on minikube, no any errors like you mentioned.

minikube delete && rm -rf ~/.minikube && rm -rf ~/.kube
minikube start --memory=12288 --cpus=4 --disk-size=30g
chectl server:deploy --platform=minikube

[benoitf]

I've the same error than Artem. (using the image built by the CI)

[vitaliy-guliy]

Strange, but OK. I will try to update the extensions to their fresh versions.

[azatsarynnyy]

I tested it on Hosted Che and dogfooding instances.

[azatsarynnyy]

Is your Che-Theia stable?

It's built by CI from this PR.

[vitaliy-guliy]

We postponed with adding of those extensions as it's unclear for now why they are not working properly with upstream Theia.
And also there are some issues that has higher priority.
So, closing this PR since a new PR with fresh versions will be opened.