Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add vscode github built-in plugin as a default plugin #877

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

  • Add vscode github built-in plugin as a default plugin.
  • Always register the github authentication provider (removed the condition of the GitHub Pull Request plugin presence).

What issues does this PR fix or reference?

fixes eclipse-che/che#18101

Release Notes

Docs PR

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@che-bot
Copy link
Contributor

che-bot commented Oct 13, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:877
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:877

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR but:

It seems I can't push to a repository, only into my fork
I tried with console-java-simple repository

image

pushing to my fork worked
but if I create another branch and then try to push it, it asks to create a fork, then I click yes but I got
image

@che-bot
Copy link
Contributor

che-bot commented Oct 13, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:877
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:877

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@vinokurig vinokurig merged commit 2f81f35 into master Oct 13, 2020
@vinokurig vinokurig deleted the che-18101 branch October 13, 2020 14:33
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
Update the vsix links for shellcheck and vale plugins to point to the
vsix files we built ourselves in https://github.com/redhat-developer/codeready-workspaces-vscode-extensions

Signed-off-by: Eric Williams <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply GitHub RemoteSourceProvider
4 participants