This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Revert "Run Che command in selected container if container doesn't specified in configuration" #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cc7871c.
evidolob
approved these changes
Jun 10, 2019
|
@monaka Please do not merge pull request that you not own |
|
@mmorhun I'm not sure how @monaka was supposed to know that. There was nothing in PR #253 to say that it depended on a different PR, and 2 committers had approved it. I think most commits are merged by committers who do not own them, @evidolob - I think it is even best practice that you do not merge your own PRs. |
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
…o registry.access.redhat.com/rhscl/httpd-24-rhel7:2.4-105 (#268) Change-Id: Ieeec90d0be83c93743affb8c191c238b44952920 Signed-off-by: nickboldt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #253 because it depends on this PR and do not work without that changes.
@monaka if you are not sure what and how a PR does, do not merge it please. If you are affected somehow, please ask about PR state.