Initial Che api for Theia #1

evidolob · 2018-11-28T08:55:55Z

Signed-off-by: Yevhen Vydolob [email protected]

Signed-off-by: Yevhen Vydolob <[email protected]>

benoitf

There is not a single comment in all the classes.
IMHO some classes should have comments to describe what they're doing
also a README file should describe the extension

extensions/eclipse-che-theia-plugin-ext/package.json

extensions/eclipse-che-theia-plugin-ext/src/common/che-protocol.ts

extensions/eclipse-che-theia-plugin-ext/src/plugin/che-workspace.ts

vitaliy-guliy · 2018-11-28T10:07:26Z

extensions/eclipse-che-theia-plugin-ext/src/common/che-protocol.ts

+
+export interface Factory {
+    workspace: WorkspaceConfig;
+    ide?: {


Does it related to CHE IDE or also to Theia?

It's just factory configuration https://www.eclipse.org/che/docs/che-6/factories_json_reference.html

Che is able to produce typescript definition of current DTOs
https://github.com/eclipse/che/blob/21318aeec878a02ee9a64453ad8e737204ccfe21/dockerfiles/lib/build.sh#L35-L44

might be good if we could reuse these definitions automatically instead of trying to duplicate it

Good catch, I will look at this

as an intermediate step, we could just move out upstream che definitions to a separate .d.ts file for now

vitaliy-guliy · 2018-11-28T10:08:44Z

extensions/eclipse-che-theia-plugin-ext/src/common/che-protocol.ts

+export interface Factory {
+    workspace: WorkspaceConfig;
+    ide?: {
+        onAppLoaded?: {


onDidLoadApplication?

vitaliy-guliy · 2018-11-28T10:09:02Z

extensions/eclipse-che-theia-plugin-ext/src/common/che-protocol.ts

+        onAppLoaded?: {
+            actions?: FactoryAction[]
+        };
+        onProjectsLoaded?: {


onDidLoadProjects

vitaliy-guliy · 2018-11-28T10:09:16Z

extensions/eclipse-che-theia-plugin-ext/src/common/che-protocol.ts

+        onProjectsLoaded?: {
+            actions?: FactoryAction[]
+        };
+        onAppClosed?: {


The same ad s above

All this fields described in factory json https://www.eclipse.org/che/docs/che-6/factories_json_reference.html

extensions/eclipse-che-theia-plugin-ext/src/common/che-protocol.ts

Signed-off-by: Yevhen Vydolob <[email protected]>

extensions/eclipse-che-theia-plugin-ext/package.json

Signed-off-by: Yevhen Vydolob <[email protected]>

evidolob · 2018-12-06T10:56:45Z

I create separate issue for Che DTO generator eclipse-che/che#12132

Signed-off-by: Yevhen Vydolob <[email protected]>

.travis.yml

extensions/eclipse-che-theia-plugin/package.json

benoitf · 2018-12-10T10:10:20Z

extensions/eclipse-che-theia-plugin/src/che.d.ts

+ *
+ * SPDX-License-Identifier: EPL-2.0
+ **********************************************************************/
+import './che-proposed';


do we need this import ?

Yes, other vice types from che-proposed is not visible in API implementation

Signed-off-by: Yevhen Vydolob <[email protected]>

Update to upstream/master.

* Update meta to match https://github.com/ws-skeleton releases

feat(generator): update report

eclipse-che/che#11306 Initial Che api for Theia

04827a9

Signed-off-by: Yevhen Vydolob <[email protected]>

evidolob self-assigned this Nov 28, 2018

evidolob requested review from benoitf and vitaliy-guliy November 28, 2018 08:55

benoitf reviewed Nov 28, 2018

View reviewed changes

vitaliy-guliy reviewed Nov 28, 2018

View reviewed changes

extensions/eclipse-che-theia-plugin-ext/src/common/che-protocol.ts Outdated Show resolved Hide resolved

vitaliy-guliy reviewed Nov 28, 2018

View reviewed changes

extensions/eclipse-che-theia-plugin-ext/src/common/che-protocol.ts Outdated Show resolved Hide resolved

vitaliy-guliy approved these changes Nov 28, 2018

View reviewed changes

eclipse-che/che#11306 fix review comments

4cdb330

Signed-off-by: Yevhen Vydolob <[email protected]>

benoitf reviewed Nov 30, 2018

View reviewed changes

extensions/eclipse-che-theia-plugin-ext/package.json Outdated Show resolved Hide resolved

eclipse-che/che#11306 set version '0.0.1'

4a9ab73

Signed-off-by: Yevhen Vydolob <[email protected]>

ashumilova mentioned this pull request Dec 4, 2018

IDE2-2018-12-25 (Sprint: 159) eclipse-che/che#12057

Closed

43 tasks

evidolob added 7 commits December 7, 2018 09:45

eclipse-che/che#11306 add some documentation

2fb3aa9

Signed-off-by: Yevhen Vydolob <[email protected]>

eclipse-che/che#11306 add 'travis' ci config

1747d8e

Signed-off-by: Yevhen Vydolob <[email protected]>

eclipse-che/che#11306 add build stage

09d9f93

Signed-off-by: Yevhen Vydolob <[email protected]>

eclipse-che/che#11306 fix version of @eclipse-che/plugin

73625b9

Signed-off-by: Yevhen Vydolob <[email protected]>

eclipse-che/che#11306 set Theia version to '0.3.17'

702097f

Signed-off-by: Yevhen Vydolob <[email protected]>

eclipse-che/che#11306 add 'Dto' suffix to Che specific objects

8a5ca6d

Signed-off-by: Yevhen Vydolob <[email protected]>

eclipse-che/che#11306 move existing API to 'proposed' file

5c68e89

Signed-off-by: Yevhen Vydolob <[email protected]>

benoitf reviewed Dec 10, 2018

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

benoitf reviewed Dec 10, 2018

View reviewed changes

extensions/eclipse-che-theia-plugin/package.json Outdated Show resolved Hide resolved

benoitf reviewed Dec 10, 2018

View reviewed changes

eclipse-che/che#11306 remove 'main' section, remove 'addons' section

8aadcfd

Signed-off-by: Yevhen Vydolob <[email protected]>

benoitf approved these changes Dec 10, 2018

View reviewed changes

evidolob merged commit 8567332 into master Dec 10, 2018

evidolob mentioned this pull request Dec 19, 2018

IDE2-2019-01-15 (Sprint: 160) eclipse-che/che#12229

Closed

34 tasks

evidolob deleted the che-api branch February 5, 2019 08:49

monaka referenced this pull request in opentestmodeling/che-theia Jul 1, 2019

Merge pull request #1 from PizzaFactory/pre-update-to-master

97da336

Update to upstream/master.

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

Update meta to match https://github.com/ws-skeleton releases (#1)

7f5ba1a

* Update meta to match https://github.com/ws-skeleton releases

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

Merge pull request #1 from benoitf/update-report-script

4895b3a

feat(generator): update report

nickboldt mentioned this pull request Jun 15, 2021

feat(CI): Add Travis CI support #1127

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial Che api for Theia #1

Initial Che api for Theia #1

evidolob commented Nov 28, 2018

benoitf left a comment

vitaliy-guliy Nov 28, 2018

evidolob Nov 28, 2018

benoitf Nov 28, 2018

evidolob Nov 28, 2018

benoitf Nov 28, 2018

vitaliy-guliy Nov 28, 2018

vitaliy-guliy Nov 28, 2018

vitaliy-guliy Nov 28, 2018

evidolob Nov 28, 2018

evidolob commented Dec 6, 2018

benoitf Dec 10, 2018

evidolob Dec 10, 2018

Initial Che api for Theia #1

Initial Che api for Theia #1

Conversation

evidolob commented Nov 28, 2018

benoitf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evidolob commented Dec 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment