Deprecate quarkus-java8 plugins #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 8 is no longer supported in Quarkus, let's deprecate these plugins and remove them after three sprints. See eclipse-che/che#16790 Signed-off-by: Eric Williams <[email protected]>
ericwill
requested review from
benoitf,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
I'm not sure this is the correct way to do it, another option is to remove all quarkus-java8 plugins with a version < 1.4. |
|
Happy path tests passed. |
…arkus-java11 Signed-off-by: Eric Williams <[email protected]>
|
Having thought about it more, the 1.2.x and 1.3.0 plugins were deprecated for awhile, so I removed them. For Quarkus Java 8 support users can use 1.3.0a, and use Quarkus on Java 11 for everything else. I've left the quarkus-java8 1.5.0 plugin deprecated in this PR -- I'll remove it in three sprints. |
|
Happy path tests passed. |
|
@sunix please take a look -- let's get this one out of the queue. |
nickboldt
reviewed
Jul 24, 2020
| @@ -10,6 +10,9 @@ icon: https://www.eclipse.org/che/images/logo-eclipseche.svg | |||
| repository: https://github.com/redhat-developer/vscode-quarkus | |||
| category: Language | |||
| firstPublicationDate: "2020-06-11" | |||
| deprecate: | |||
| automigrate: true | |||
| migrateTo: redhat/quarkus-java11/latest | |||
There was a problem hiding this comment.
does this also mean updating the quarkus devfile(s) so they're compatible with java11 instead of java8?
monaka
pushed a commit
to PizzaFactory/che-plugin-registry
that referenced
this pull request
Aug 8, 2020
* Remove some quarkus-java8 plugins and migrate quarkus-java8 1.5 to quarkus-java11 See eclipse-che/che#16790 Signed-off-by: Eric Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 8 is no longer supported in Quarkus, let's deprecate these plugins and remove them after three sprints.
See eclipse-che/che#16790
Signed-off-by: Eric Williams [email protected]