Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-openshift-connector #468

Merged
merged 6 commits into from
May 26, 2020
Merged

Update vscode-openshift-connector #468

merged 6 commits into from
May 26, 2020

Conversation

ericwill
Copy link
Contributor

Update the latest version to 0.1.5.

Closes eclipse-che/che#16178

Signed-off-by: Eric Williams [email protected]

Update the latest version to 0.1.5.

Closes eclipse-che/che#16178

Signed-off-by: Eric Williams <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented May 20, 2020

Happy path tests passed.

@vinokurig
Copy link
Contributor

The plugin is not displayed, however it exists in the plugin's list:
screenshot-che-che 192 168 99 253 nip io-2020 05 21-18_20_20

@ericwill
Copy link
Contributor Author

Do the commands work as expected?

@vinokurig
Copy link
Contributor

The commands are not registered as well

@ericwill
Copy link
Contributor Author

Interesting. I just tried testing the Jira/Bitbucket extension in Che and it also was not registered/found. Maybe there is some issue elsewhere?

@vinokurig
Copy link
Contributor

I've tried the older version and it worked as usual

@ericwill
Copy link
Contributor Author

Taking another look I see the container is killed off with OOMKilled error. I'll investigate.

@ericwill
Copy link
Contributor Author

Upping the memory to 2GB seems to work for now -- the workspace starts and the plugin views/commands are registered.

However as soon as I open the OpenShift connector view, I see an error message:
Activating extension che-theia.che-openshift-authentication-plugin failed: Cannot read property 'getProviders' of undefined.

@vinokurig
Copy link
Contributor

That's because you are using not the latest editor. Set the editor's version to latest to apply the latest plugin API

@che-bot
Copy link
Contributor

che-bot commented May 21, 2020

Happy path tests passed.

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented May 21, 2020

Happy path tests passed.

@vinokurig
Copy link
Contributor

oc is missing in the sidecar container:
screenshot-che-che 192 168 99 253 nip io-2020 05 22-15_39_20

@ericwill
Copy link
Contributor Author

ericwill commented May 22, 2020

I tested on hosted Che and all seems to be well, except after I authenticate and return to the workspace I see this error:

Failed to authenticated the OpenShift connector plugin: error: not a valid URL: parse https://172.30.0.1:443 OpenShift: v3.11.82: net/url: invalid control character in URL

@vinokurig since this version of the connector uses OpenShift 4 is it possible some work may need to be done in the authentication plugin?

@che-bot
Copy link
Contributor

che-bot commented May 22, 2020

Happy path tests passed.

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented May 22, 2020

Happy path tests passed.

@che-bot
Copy link
Contributor

che-bot commented May 22, 2020

Happy path tests passed.

@vinokurig
Copy link
Contributor

The output of the odo version command was changed, working on aligning the oauth plugin.

@ericwill
Copy link
Contributor Author

The output of the odo version command was changed, working on aligning the oauth plugin.

Okay, I'll hold off on merging here and will update the PR to include the new auth plugin version once it's released.

@vinokurig
Copy link
Contributor

Should be fixed by che-incubator/che-theia-openshift-auth#2, @ericwill could you please review the PR

Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the basic functionality on local minishift.

@vinokurig
Copy link
Contributor

It still fails on hosted Che but that's another issue: eclipse-che/che#17020

@che-bot
Copy link
Contributor

che-bot commented May 26, 2020

Happy path tests passed.

@ericwill ericwill merged commit 6b40812 into eclipse-che:master May 26, 2020
@benoitf benoitf added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode-openshift-connector needs to be updated to v0.1.5
5 participants