-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vscode-openshift-connector #468
Update vscode-openshift-connector #468
Conversation
Update the latest version to 0.1.5. Closes eclipse-che/che#16178 Signed-off-by: Eric Williams <[email protected]>
Happy path tests passed. |
Do the commands work as expected? |
The commands are not registered as well |
Interesting. I just tried testing the Jira/Bitbucket extension in Che and it also was not registered/found. Maybe there is some issue elsewhere? |
I've tried the older version and it worked as usual |
Taking another look I see the container is killed off with |
Signed-off-by: Eric Williams <[email protected]>
Signed-off-by: Eric Williams <[email protected]>
Upping the memory to 2GB seems to work for now -- the workspace starts and the plugin views/commands are registered. However as soon as I open the OpenShift connector view, I see an error message: |
That's because you are using not the latest editor. Set the editor's version to |
Happy path tests passed. |
1 similar comment
Happy path tests passed. |
Signed-off-by: Eric Williams <[email protected]>
Signed-off-by: Eric Williams <[email protected]>
I tested on hosted Che and all seems to be well, except after I authenticate and return to the workspace I see this error:
@vinokurig since this version of the connector uses OpenShift 4 is it possible some work may need to be done in the authentication plugin? |
Happy path tests passed. |
2 similar comments
Happy path tests passed. |
Happy path tests passed. |
The output of the |
Okay, I'll hold off on merging here and will update the PR to include the new auth plugin version once it's released. |
Should be fixed by che-incubator/che-theia-openshift-auth#2, @ericwill could you please review the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the basic functionality on local minishift.
It still fails on hosted Che but that's another issue: eclipse-che/che#17020 |
Signed-off-by: Eric Williams <[email protected]>
Happy path tests passed. |
Update the latest version to 0.1.5.
Closes eclipse-che/che#16178
Signed-off-by: Eric Williams [email protected]