Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next and latest versions of che-idea and che-pycharm editors #1177

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

svor
Copy link
Contributor

@svor svor commented Jan 17, 2022

Signed-off-by: Vladyslav Zhukovskyi [email protected]

What does this PR do?

This changes proposal updates existed version of che-idea and che-pycharm editors to next ones and adds two version of latest released version after release tagged images: https://github.com/che-incubator/jetbrains-editor-images/releases/tag/20220117.828e6c5 which supports sidecar-less model.

Signed-off-by: Vladyslav Zhukovskyi [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20863

How to test this PR?

  • che-idea:latest
https://<your-che-host>/dashboard/#https://github.com/che-incubator/jetbrains-editor-images?che-editor=https://gist.githubusercontent.com/vzhukovs/55caad47363e1b4f3d4a6ab3fe85a03a/raw/508747d502a557cd3e14ea352b35ed8798b98977/devfile.yaml
  • che-idea:next
https://<your-che-host>/dashboard/#https://github.com/che-incubator/jetbrains-editor-images?che-editor=https://gist.githubusercontent.com/vzhukovs/55caad47363e1b4f3d4a6ab3fe85a03a/raw/f9394bbd925af1798b8a42feb0dfb5d3be8955b8/devfile.yaml
  • che-pycharm:latest
https://<your-che-host>/dashboard/#https://github.com/che-incubator/jetbrains-editor-images?che-editor=https://gist.githubusercontent.com/vzhukovs/55caad47363e1b4f3d4a6ab3fe85a03a/raw/c86c2542574dc16118107eb247c85b9da3946b6d/devfile.yaml
  • che-pycharm:next
https://<your-che-host>/dashboard/#https://github.com/che-incubator/jetbrains-editor-images?che-editor=https://gist.githubusercontent.com/vzhukovs/55caad47363e1b4f3d4a6ab3fe85a03a/raw/3a73701a98b264eb6e7d377774792cbeb8a94d4d/devfile.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@@ -530,13 +530,13 @@ editors:
volume: {}
- schemaVersion: 2.1.0
metadata:
name: che-incubator/che-idea/2020.3.4-next
name: che-incubator/che-idea/next
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for che-idea/next, maybe the tag of the image should be :next as well (and not 2020.3.4-next)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hasn't configured in GitHub actions yet, but it is possible to do that. We can create an issue for that and update next tags on the next iteration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created the issue for that: eclipse-che/che#21031

icon: https://resources.jetbrains.com/storage/products/pycharm/img/meta/pycharm_logo_300x300.png
attributes:
publisher: che-incubator
version: 2020.3.5
version: next
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need to update as well

quay.io/che-incubator/che-pycharm:2020.3.5-next --> quay.io/che-incubator/che-pycharm:next

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2022
@svor svor changed the title WIP Add next and latest versions of che-idea and che-pycharm editors Add next and latest versions of che-idea and che-pycharm editors Jan 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vzhukovs vzhukovs merged commit 422a0d0 into main Jan 17, 2022
@vzhukovs vzhukovs deleted the sv-jetbrains_editor_configuration branch January 17, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants