-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add next and latest versions of che-idea and che-pycharm editors #1177
Conversation
Signed-off-by: Vladyslav Zhukovskyi <[email protected]>
@@ -530,13 +530,13 @@ editors: | |||
volume: {} | |||
- schemaVersion: 2.1.0 | |||
metadata: | |||
name: che-incubator/che-idea/2020.3.4-next | |||
name: che-incubator/che-idea/next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for che-idea/next, maybe the tag of the image should be :next as well (and not 2020.3.4-next)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It hasn't configured in GitHub actions yet, but it is possible to do that. We can create an issue for that and update next tags on the next iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created the issue for that: eclipse-che/che#21031
icon: https://resources.jetbrains.com/storage/products/pycharm/img/meta/pycharm_logo_300x300.png | ||
attributes: | ||
publisher: che-incubator | ||
version: 2020.3.5 | ||
version: next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably need to update as well
quay.io/che-incubator/che-pycharm:2020.3.5-next
--> quay.io/che-incubator/che-pycharm:next
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benoitf, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vladyslav Zhukovskyi [email protected]
What does this PR do?
This changes proposal updates existed version of
che-idea
andche-pycharm
editors tonext
ones and adds two version of latest released version after release tagged images: https://github.com/che-incubator/jetbrains-editor-images/releases/tag/20220117.828e6c5 which supports sidecar-less model.Signed-off-by: Vladyslav Zhukovskyi [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20863
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.