Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable plugin registry if openVSX registry is configured #1843

Merged
merged 11 commits into from
Jun 4, 2024
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented May 22, 2024

What does this PR do?

feat: Disable plugin registry if openVSX registry is configured

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#22932

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented May 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha marked this pull request as ready for review May 27, 2024 09:59
@tolusha tolusha requested review from SDawley and ibuziuk as code owners May 27, 2024 09:59
tolusha added 11 commits June 3, 2024 17:00
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha
Copy link
Contributor Author

tolusha commented Jun 3, 2024

/test v14-devworkspace-happy-path

2 similar comments
@tolusha
Copy link
Contributor Author

tolusha commented Jun 3, 2024

/test v14-devworkspace-happy-path

@tolusha
Copy link
Contributor Author

tolusha commented Jun 3, 2024

/test v14-devworkspace-happy-path

@tolusha
Copy link
Contributor Author

tolusha commented Jun 4, 2024

/retest

Copy link

openshift-ci bot commented Jun 4, 2024

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy ff70fbd link true /test v14-che-behind-proxy
ci/prow/v14-devworkspace-happy-path ff70fbd link true /test v14-devworkspace-happy-path
ci/prow/v14-upgrade-stable-to-next ff70fbd link true /test v14-upgrade-stable-to-next
ci/prow/v14-operator-test ff70fbd link true /test v14-operator-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tolusha
Copy link
Contributor Author

tolusha commented Jun 4, 2024

All tests passed locally.
The PR can be merged

@tolusha tolusha merged commit 618ad1f into main Jun 4, 2024
16 of 21 checks passed
@tolusha tolusha deleted the 22932_3 branch June 4, 2024 08:42
@devstudio-release
Copy link

Build 3.15 :: operator_3.x/370: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.15 :: operator_3.x/370: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6934 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6881: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61665607 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6882: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61666664 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants