Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add TokenValidityCheck On OpenShift for che-dashboard #1366

Closed
wants to merge 1 commit into from

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Apr 28, 2022

Signed-off-by: Oleksii Orel [email protected]

What does this PR do?

Add TokenValidityCheck On OpenShift for che-dashboard.

What issues does this PR fix or reference?

fixes eclipse-che/che#21352

How to test this PR?

It could be tested with platform openshift and this che-operator image: docker.io/olexii4dockerid/che-operator:next.

  1. Deploy Che.

Example:

chectl server:deploy \
    --installer=operator \
    --platform=openshift \
    --che-operator-image=docker.io/olexii4dockerid/che-operator:next
  1. Try to accept factory with URL without being logged in, like
    $CHE_HOST#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2.
  2. Check that Dashboard is opened with factory flow
    $CHE_HOST/dashboard/#/load-factory?url=https://github.com/che-samples/java-spring-petclinic/tree/devfilev2. And the load-factory page has loaded without any errors.

2022-04-28_20_58_12

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #1366 (bd14238) into main (2fdc36e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1366   +/-   ##
=======================================
  Coverage   61.81%   61.81%           
=======================================
  Files          76       76           
  Lines        6236     6236           
=======================================
  Hits         3855     3855           
  Misses       1998     1998           
  Partials      383      383           
Impacted Files Coverage Δ
pkg/deploy/dashboard/dashboard.go 50.98% <100.00%> (+0.98%) ⬆️
pkg/deploy/gateway/gateway.go 83.50% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fdc36e...bd14238. Read the comment docs.

@olexii4 olexii4 marked this pull request as ready for review April 28, 2022 18:06
@tolusha
Copy link
Contributor

tolusha commented Apr 29, 2022

/test v9-devworkspace-happy-path

1 similar comment
@tolusha
Copy link
Contributor

tolusha commented Apr 29, 2022

/test v9-devworkspace-happy-path

@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4, sparkoo, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 changed the title Add TokenValidityCheck On OpenShift for che-dashboard [WIP] Add TokenValidityCheck On OpenShift for che-dashboard Apr 29, 2022
@olexii4 olexii4 changed the title [WIP] Add TokenValidityCheck On OpenShift for che-dashboard [wip] Add TokenValidityCheck On OpenShift for che-dashboard Apr 29, 2022
@tolusha
Copy link
Contributor

tolusha commented Apr 29, 2022

/test v9-devworkspace-happy-path

@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v9-devworkspace-happy-path 9cd32fc link true /test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@olexii4
Copy link
Contributor Author

olexii4 commented May 2, 2022

I have a problem now:
2022-05-02_15_54_22

@olexii4 olexii4 closed this May 10, 2022
@olexii4 olexii4 deleted the CHE-21352 branch May 10, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My daily authentication dance
3 participants