Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add projects section into devfile spec document #842

Merged
merged 5 commits into from
Oct 23, 2019
Merged

Add projects section into devfile spec document #842

merged 5 commits into from
Oct 23, 2019

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Oct 11, 2019 •
edited
Loading

Signed-off-by: Mykola Morhun [email protected]

What does this PR do?

Adds new Adding projects to a devfile section into devfile specification chapter.
Adds docs for sparseCheckoutDir feature.
Fixes some indents and clonePath parameters position.

What issues does this PR fix or reference?

eclipse-che/che#13671

@mmorhun mmorhun added the Che-7 label Oct 11, 2019
@mmorhun mmorhun self-assigned this Oct 11, 2019
@mmorhun mmorhun mentioned this pull request Oct 11, 2019
Merged
@AndrienkoAleksandr
Copy link
Contributor

Great job!

@mmorhun
Fix typo
8d06f33 
Signed-off-by: Mykola Morhun <[email protected]>
@mmorhun
Copy link
Contributor Author

mmorhun commented Oct 18, 2019 •
edited
Loading

@rkratky please take a look

@mmorhun mmorhun mentioned this pull request Oct 21, 2019
Merged
@mmorhun
Copy link
Contributor Author

mmorhun commented Oct 22, 2019

I would like to merge implementation with documentation. @rkratky please take a look at this one...

@rkratky rkratky mentioned this pull request Oct 22, 2019
Merged
rkratky
rkratky suggested changes Oct 22, 2019
View reviewed changes
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmorhun, apologies for the delay. I submitted a PR (#860) against your branch with suggested language and formatting improvements.

@rkratky
Copy link

rkratky commented Oct 23, 2019

@mmorhun, please merge whenever you're ready.

@mmorhun mmorhun merged commit 7f8096e into master Oct 23, 2019
@mmorhun mmorhun deleted the CHE-13671 branch October 23, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkratky rkratky rkratky approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@slemeur slemeur Awaiting requested review from slemeur

@themr0c themr0c Awaiting requested review from themr0c

Assignees

@mmorhun mmorhun

Labels
Che-7 kind/task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmorhun @AndrienkoAleksandr @rkratky @che-bot