Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: How to configure custom editors definitions #2738

Merged
merged 17 commits into from
Jun 12, 2024
Merged

feat: How to configure custom editors definitions #2738

merged 17 commits into from
Jun 12, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented May 28, 2024 •
edited
Loading

What does this pull request change?

feat: How to configure custom editors definitions

What issues does this pull request fix or reference?

eclipse-che/che#22932

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚡️ Deploying pull request preview...

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Click here to review and test in web IDE: Contribute

tolusha added 2 commits May 28, 2024 13:57
@tolusha
fixup
8208a8e 
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha
fixup
713477b 
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha tolusha marked this pull request as ready for review June 3, 2024 10:41
@tolusha tolusha requested review from deerskindoll and a team as code owners June 3, 2024 10:41
@tolusha tolusha requested a review from amisevsk June 3, 2024 10:41
@dkwon17
Copy link
Contributor

dkwon17 commented Jun 6, 2024

It looks great, I just have some suggestions

tolusha and others added 9 commits June 7, 2024 11:54
@tolusha @dkwon17
Update modules/administration-guide/pages/configuring-editors-definit…
87e1136 
…ions.adoc

Co-authored-by: David Kwon <[email protected]>
@tolusha @dkwon17
Update modules/administration-guide/pages/configuring-editors-definit…
cbd75c4 
…ions.adoc

Co-authored-by: David Kwon <[email protected]>
@tolusha @dkwon17
Update modules/administration-guide/pages/configuring-editors-definit…
9b34d9d 
…ions.adoc

Co-authored-by: David Kwon <[email protected]>
@tolusha @dkwon17
Update modules/administration-guide/pages/configuring-editors-definit…
96a67e2 
…ions.adoc

Co-authored-by: David Kwon <[email protected]>
@tolusha @dkwon17
Update modules/administration-guide/pages/configuring-editors-definit…
ea93ad8 
…ions.adoc

Co-authored-by: David Kwon <[email protected]>
@tolusha @dkwon17
Update modules/administration-guide/pages/configuring-editors-definit…
537560b 
…ions.adoc

Co-authored-by: David Kwon <[email protected]>
@tolusha @dkwon17
Update modules/administration-guide/pages/configuring-editors-definit…
c304b69 
…ions.adoc

Co-authored-by: David Kwon <[email protected]>
@tolusha @dkwon17
Update modules/administration-guide/pages/configuring-editors-definit…
66467e8 
…ions.adoc

Co-authored-by: David Kwon <[email protected]>
@tolusha @dkwon17
Update modules/administration-guide/pages/configuring-editors-definit…
e2f238a 
…ions.adoc

Co-authored-by: David Kwon <[email protected]>
@ibuziuk ibuziuk mentioned this pull request Jun 7, 2024
Closed
deerskindoll
deerskindoll reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a a couple of tweaks. I noticed the value descriptions are sometimes treated as sentences ending in a period and sometimes aren't. I suggest you pick one option and stick to it.

modules/administration-guide/pages/configuring-editors-definitions.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/configuring-editors-definitions.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/configuring-editors-definitions.adoc Outdated Show resolved Hide resolved
modules/administration-guide/pages/configuring-editors-definitions.adoc Outdated Show resolved Hide resolved
deerskindoll
deerskindoll approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tolusha tolusha merged commit 0fbb61c into main Jun 12, 2024
9 of 10 checks passed
@tolusha tolusha deleted the 22932 branch June 12, 2024 13:43
@ibuziuk ibuziuk mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwon17 dkwon17 dkwon17 left review comments

@ibuziuk ibuziuk ibuziuk approved these changes

@deerskindoll deerskindoll deerskindoll approved these changes

@amisevsk amisevsk Awaiting requested review from amisevsk amisevsk is a code owner automatically assigned from eclipse-che/ecd-che-docs-reviewers

Assignees
No one assigned
Labels
None yet
Projects
Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tolusha @dkwon17 @ibuziuk @deerskindoll