-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Restrict the total number of 'Running' workspaces on a cluster #1173
Conversation
...omponents/WorkspaceProgress/CommonSteps/CheckRunningWorkspacesLimit/__tests__/index.spec.tsx
Outdated
Show resolved
Hide resolved
...omponents/WorkspaceProgress/CommonSteps/CheckRunningWorkspacesLimit/__tests__/index.spec.tsx
Outdated
Show resolved
Hide resolved
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1173 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1173", name: che-dashboard}]}}]" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
- Coverage 90.04% 90.02% -0.03%
==========================================
Files 432 438 +6
Lines 44763 45269 +506
Branches 3095 3102 +7
==========================================
+ Hits 40309 40752 +443
- Misses 4416 4481 +65
+ Partials 38 36 -2 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1173 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1173", name: che-dashboard}]}}]" |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1173 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1173", name: che-dashboard}]}}]" |
...s/dashboard-backend/src/devworkspaceClient/services/__tests__/devWorkspaceClusterApi.spec.ts
Outdated
Show resolved
Hide resolved
...s/dashboard-backend/src/devworkspaceClient/services/__tests__/devWorkspaceClusterApi.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1173 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1173", name: che-dashboard}]}}]" |
Signed-off-by: Anatolii Bazko <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1173 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1173", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.17 :: dashboard_3.x/534: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7666: Console, Changes, Git Data |
What does this PR do?
feat: Restrict the total number of 'Running' workspaces on a cluster
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#23081
Is it tested? How?
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1173", name: che-dashboard}]}}]"
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/devEnvironments/maxNumberOfRunningWorkspacesPerCluster", "value": 1}]"
Release Notes
```Introduced a new configuration option,
maxNumberOfRunningWorkspacesPerCluster
, to limit the total number of 'Running' workspaces on a cluster. When the limit is reached, users attempting to start additional workspaces will receive an error message.Docs PR
TODO