fix: check if ssh key has newline at the end

[akurinnoy]

What does this PR do?

This PR fixes an issue where the trailing newline was lost when copy-pasting SSH keys.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

fixes eclipse-che/che#23073

Is it tested? How?

Based on eclipse-che/che#23073 (comment):

1. Generate an SSH key locally
2. Go to Dashboard -> User Preferences -> SSH Keys
3. Click Add SSH Key
4. IMPORTANT: extract the content of the generated public and private keys and paste it manually to the inputs.
5. Save the key
6. Try to start a workspace from an ssh url e.g. [email protected]:vinokurig/test.git
7. When the workspace starts, the project should be cloned.

Release Notes

Docs PR

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1168

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1168", name: che-dashboard}]}}]"

[ibuziuk]

cc: @dmytro-ndp would be nice to backport it to 7.90.x

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (5eb0a3a) to head (2489712).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   90.03%   89.91%   -0.13%     
==========================================
  Files         432      432              
  Lines       44705    44718      +13     
  Branches     3073     3077       +4     
==========================================
- Hits        40250    40206      -44     
- Misses       4419     4476      +57     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[olexii4]

LGTM

[dmytro-ndp]

@akurinnoy : I have checked Eclipse Che next with https://quay.io/repository/eclipse/che-dashboard:pr-1168 and following test scenario descried i PR description.

Workspace has started successfully from [email protected]:vinokurig/test.git and project has been cloned at step 7 having SSH private key uploaded without trailing end of line:

Good job!

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, dmytro-ndp, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devstudio-release]

Build 3.17 :: dashboard_3.x/529: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: sync-to-downstream_3.x/7522: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7503: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: push-latest-container-to-quay_3.x/4883: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7503:

dashboard : 3.x :: Build 63476180 : quay.io/devspaces/dashboard-rhel8:3.17-9
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4883 triggered

[devstudio-release]

Build 3.17 :: update-digests_3.x/7359: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: dashboard_3.x/529:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7522 triggered

[devstudio-release]

Build 3.17 :: operator-bundle_3.x/3488: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: sync-to-downstream_3.x/7523: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7504: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7504:

devspaces-operator-bundle : 3.x :: Failed in 63477219 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay