Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Git provider endpoint validation #1140

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: Git provider endpoint validation #1140

merged 1 commit into from
Jul 3, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jul 2, 2024

What does this PR do?

This PR fixes Git provider endpoint validation.

What issues does this PR fix or reference?

fixes eclipse-che/che#23013

@olexii4 olexii4 requested review from akurinnoy and ibuziuk as code owners July 2, 2024 13:01
@che-bot
Copy link
Contributor

che-bot commented Jul 2, 2024

Click here to review and test in web IDE: Contribute

Copy link

openshift-ci bot commented Jul 2, 2024

@olexii4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-e2e-puppeteer 84478a8 link true /test v14-e2e-puppeteer
ci/prow/v14-dashboard-happy-path 84478a8 link true /test v14-dashboard-happy-path
ci/prow/v14-images 84478a8 link true /test v14-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

github-actions bot commented Jul 2, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1140

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1140", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit da0abc7 into main Jul 3, 2024
13 of 16 checks passed
@olexii4 olexii4 deleted the CHE-23013 branch July 3, 2024 13:38
@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/505: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/505: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7043 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/7020: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62349867 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Ports in Git Provider Endpoint for Dashboard - Personal Access Tokens
5 participants